build_container: install pipewire and virglrenderer from ubuntu repos and cleanups #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next commit removes calls to `ninja` that perhaps called `ldconfig` autmatically. Without this, `vhost-device-gpu` is unable to find `libgfxstream_backend.so.0`. Signed-off-by: Stefano Garzarella <[email protected]>
We have recently moved to Ubuntu 24.04. The pipewire and virglrenderer libraries provided by the Ubuntu repos are now new enough to test vhost-device crates, so we can avoid installing them manually. Signed-off-by: Stefano Garzarella <[email protected]>
Let's clean up the git clones a bit, always using depth=1 to be faster and directly checkout the branch needed. Let's make the script a little more readable by also adding some comments, like the crate that needs the dependency. Signed-off-by: Stefano Garzarella <[email protected]>
stefano-garzarella
requested review from
andreeaflorescu,
lauralt,
stsquad,
roypat,
ShadowCurse and
RuoqingHe
as code owners
RuoqingHe
approved these changes
Mar 6, 2025
roypat
approved these changes
Mar 6, 2025
RuoqingHe
added a commit
to RuoqingHe/rust-vmm-ci
that referenced
this pull request
Mar 7, 2025
We are missing `rsync` for `seccompiler`. And after bumping to ubuntu:24.04, some dependencies required by `vhost-devices` could be installed from ubuntu sources, so @@stefano-garzarella reworked the preparation of `vhost-devices` dependencies in rust-vmm/rust-vmm-container#128. Update to g82bd1a3 dev image to apply the changes. Signed-off-by: Ruoqing He <[email protected]>
4 tasks
RuoqingHe
added a commit
to RuoqingHe/rust-vmm-ci
that referenced
this pull request
Mar 7, 2025
We are missing `rsync` for `seccompiler`. And after bumping to ubuntu:24.04, some dependencies required by `vhost-devices` could be installed from ubuntu sources, so @stefano-garzarella reworked the preparation of `vhost-devices` dependencies in rust-vmm/rust-vmm-container#128. Update to g82bd1a3 dev image to apply the changes. Signed-off-by: Ruoqing He <[email protected]>
stefano-garzarella
pushed a commit
to rust-vmm/rust-vmm-ci
that referenced
this pull request
Mar 7, 2025
We are missing `rsync` for `seccompiler`. And after bumping to ubuntu:24.04, some dependencies required by `vhost-devices` could be installed from ubuntu sources, so @stefano-garzarella reworked the preparation of `vhost-devices` dependencies in rust-vmm/rust-vmm-container#128. Update to g82bd1a3 dev image to apply the changes. Signed-off-by: Ruoqing He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
We have recently moved to Ubuntu 24.04. The pipewire and virglrenderer libraries provided by the Ubuntu repos are now new enough to test vhost-device crates, so we can avoid installing them manually.
This fixes issue in rust-vmm/vhost-device#825
Already tested locally.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.