Adjust AdvancedTreeSearch for CtcTreeBuilder support #102
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larissakl
requested review from
curufinwe and
SimBe195
and removed request for
curufinwe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just minor adjustments to make the
AdvancedTreeSearchwork with theCtcTreeBuilder:Modified two if-statements related to the
stateDepthswhich caused segmentation faults due to the self-loops in the CTC tree.Two assertions didn’t apply to the CTC tree, as its root state logic is significantly simpler. These assertions are now only checked if the
CtcTreeBuilderis not used, so the previous behavior remains unchanged.