-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop older Python support / increase min required Python version #195
Comments
Ping? @curufinwe @michelwi @dthulke ? |
Currently CI fails with this message: > This is a scheduled Ubuntu 20.04 brownout. Ubuntu 20.04 LTS runner will be removed on 2025-04-01. For more details, see actions/runner-images#11101 > > GitHub Actions has encountered an internal error when running your job. I assume this would be fixed by this update. Somewhat related is #195.
Bumping would be fine with me, as all our recipes already require @dthulke, @patrick-wilken @RaphaelLilt you are using different recipe collections, would bumping the minimum required python version break your workflows? |
I'm currently using Python 3.11 so the bump would be fine with me. |
Same here, we're on 3.10. |
Ok, so I guess it is Python 3.8 then. Or even newer? Where should this be put? CI run with this, so for the GitHub Actions configs. Maybe also README somewhere. What else? |
#245 takes care of this 👍
yes, this is written explicitly in the readme Line 10 in fabafb8
Here is what I found with a quick search: Line 2 in fabafb8
Line 3 in fabafb8
sisyphus/.pre-commit-config.yaml Line 7 in fabafb8
sisyphus/docs/installation.rst Line 15 in fabafb8
sisyphus/docs/aws_batch_docker/Dockerfile Line 12 in fabafb8
|
I think we also should wait for @curufinwe's feedback on this. He might know about some other setups. |
I just want to open this issue to discuss this, and also on what version we want to increase to.
On RETURNN, currently we require
Python 3.7Python 3.8. See rwth-i6/returnn#487, rwth-i6/returnn#1326 for some discussion and also what features are available since Python 3.8 (or closeby versions).Python >=3.8 is required for i6_core: rwth-i6/i6_core#409, rwth-i6/i6_core#408
Python >=3.8 is also required for i6_models: rwth-i6/i6_models#11.
The text was updated successfully, but these errors were encountered: