Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop older Python support / increase min required Python version #195

Open
albertz opened this issue Jul 3, 2024 · 7 comments
Open

Drop older Python support / increase min required Python version #195

albertz opened this issue Jul 3, 2024 · 7 comments

Comments

@albertz
Copy link
Member

albertz commented Jul 3, 2024

I just want to open this issue to discuss this, and also on what version we want to increase to.

On RETURNN, currently we require Python 3.7 Python 3.8. See rwth-i6/returnn#487, rwth-i6/returnn#1326 for some discussion and also what features are available since Python 3.8 (or closeby versions).

Python >=3.8 is required for i6_core: rwth-i6/i6_core#409, rwth-i6/i6_core#408

Python >=3.8 is also required for i6_models: rwth-i6/i6_models#11.

@albertz
Copy link
Member Author

albertz commented Mar 4, 2025

Ping? @curufinwe @michelwi @dthulke ?

albertz added a commit that referenced this issue Mar 4, 2025
Currently CI fails with this message:

> This is a scheduled Ubuntu 20.04 brownout. Ubuntu 20.04 LTS runner will be removed on 2025-04-01. For more details, see actions/runner-images#11101
>
> GitHub Actions has encountered an internal error when running your job.

I assume this would be fixed by this update.

Somewhat related is #195.
@michelwi
Copy link
Contributor

michelwi commented Mar 4, 2025

Bumping would be fine with me, as all our recipes already require Python >=3.8 as you said.

@dthulke, @patrick-wilken @RaphaelLilt you are using different recipe collections, would bumping the minimum required python version break your workflows?

@RaphaelLilt
Copy link
Contributor

I'm currently using Python 3.11 so the bump would be fine with me.

@patrick-wilken
Copy link
Contributor

Same here, we're on 3.10.

@albertz
Copy link
Member Author

albertz commented Mar 4, 2025

Ok, so I guess it is Python 3.8 then. Or even newer?

Where should this be put? CI run with this, so for the GitHub Actions configs. Maybe also README somewhere. What else?

@michelwi
Copy link
Contributor

michelwi commented Mar 4, 2025

so I guess it is Python 3.8 then. Or even newer?
I would propose 3.8 for now and we can come back to this once we need newer features.

Where should this be put? CI run with this, so for the GitHub Actions configs.

#245 takes care of this 👍

Maybe also README somewhere.

yes, this is written explicitly in the readme

Sisyphus requires a Python >=3.6 installation with the following additional libraries:

What else?

Here is what I found with a quick search:

envlist = py35

target-version = ["py37"]

python: python3.6

Independent of the used scheduler engine, Sisyphus requires a Python 3.5 installation with the following additional libraries:

RUN cp -a /opt/sisyphus/sisyphus /usr/local/lib/python3.6/dist-packages/

@albertz
Copy link
Member Author

albertz commented Mar 4, 2025

I think we also should wait for @curufinwe's feedback on this. He might know about some other setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants