Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in torsion_bounds function for elliptic curves #39620

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DaveWitteMorris
Copy link
Member

Fixes #39580. As pointed out in #39580, the torsion_bounds method of elliptic curves has a bug in its handling of the situation where the monic defining polynomial of the number field has nontrivial denominators in some of its coefficients.

Diagnosis. Assume E is an elliptic curve over a number field K, and let f be a monic defining polynomial of K, so a root a_ of f generates K. The code for torsion_bounds replaces f with a different polynomial (still called f, but obtained by rescaling the variable) that is monic and integral. The code erroneously assumes that a_ is a root of this new polynomial. To fix this, we can rescale a root of the new polynomial, to obtain a root of the original one.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Mar 2, 2025

Documentation preview for this PR (built with commit 67cab64; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when computing torsion group
1 participant