Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable package installation #48

Closed
2 of 3 tasks
s1hofmann opened this issue May 26, 2020 · 0 comments
Closed
2 of 3 tasks

Enable package installation #48

s1hofmann opened this issue May 26, 2020 · 0 comments
Assignees
@cliffle
Labels
enhancement New feature or request

Comments

@s1hofmann
Copy link
Contributor

s1hofmann commented May 26, 2020 •
edited by cliffle
Loading

Currently it is not possible to install 3rd party dependencies in a Sakuli container.

No install step is performed, thus no dependencies are installed before running a test, which reduces flexibility. It also causes problems since mounted node_modules might clash when running a container on e.g. macOS, since native dependencies of nut-js will be incompatible.

As a Sakuli user I want to be able to use 3rd party dependencies in my container environment.

Acc. crit.:

  • 3rd party packages can be installed in containers
  • Mounted node_modules are discarded to avoid platform dependent incompatibilities
  • Installation of 3rd party packages is implemented as an opt-in
@s1hofmann s1hofmann added the enhancement New feature or request label May 26, 2020
@cliffle cliffle self-assigned this Dec 4, 2020
cliffle added a commit that referenced this issue Dec 7, 2020
@cliffle
(#48) update changelog
772696b
cliffle added a commit that referenced this issue Dec 7, 2020
@cliffle
(#48) added test with puppeteer
850a5c5
cliffle added a commit that referenced this issue Dec 7, 2020
@cliffle
(#48) added install step when INSTALL_PACKAGES is true
3a0b6b5
cliffle added a commit that referenced this issue Dec 7, 2020
@cliffle
(#48) fixed puppeteer test / chromium needs to start without sandbox
9974465
cliffle added a commit to sakuli/docs that referenced this issue Dec 7, 2020
@cliffle
(sakuli/sakuli-docker#48) added docs for 3rd party package installati…
061e9b2 
…on inside the container
cliffle added a commit that referenced this issue Dec 7, 2020
@cliffle
(#48) add timeout after navigating to new page
61e4e54
svettwer added a commit to sakuli/docs that referenced this issue Dec 11, 2020
@svettwer
(sakuli/sakuli-docker#48) wording
548599e
svettwer added a commit to sakuli/docs that referenced this issue Dec 11, 2020
@svettwer
Merge pull request #84 from sakuli/docs/(sakuli/sakuli-docker#48)/ins…
1e60c77 
…tall-3rd-party-packages

(sakuli/sakuli-docker#48) added docs for 3rd party package installati…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cliffle cliffle

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@s1hofmann @svettwer @cliffle