Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search-app deploy #1182

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Fix search-app deploy #1182

merged 7 commits into from
Jan 30, 2024

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Jan 30, 2024 •
edited
Loading

Scope of the PR

This PR moves a bit scripts related to deploy to fix issue with missing route manifest on vercel deployment.

Related issues

Fixes #SHOPX-107

Checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: da95200

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

11 Ignored Deployments
Name Status Preview Comments Updated (UTC)
saleor-app-cms ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 2:40pm
saleor-app-crm ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 2:40pm
saleor-app-data-importer ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 2:40pm
saleor-app-emails-and-messages ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 2:40pm
saleor-app-invoices ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 2:40pm
saleor-app-klaviyo ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 2:40pm
saleor-app-products-feed ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 2:40pm
saleor-app-search ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 2:40pm
saleor-app-segment ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 2:40pm
saleor-app-slack ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 2:40pm
saleor-app-taxes ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 2:40pm

@krzysztofzuraw krzysztofzuraw changed the title Trigger deploy Fix search app deploy Jan 30, 2024
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review January 30, 2024 08:29
@krzysztofzuraw krzysztofzuraw requested a review from a team as a code owner January 30, 2024 08:29
@krzysztofzuraw krzysztofzuraw requested a review from a team January 30, 2024 08:29
@krzysztofzuraw krzysztofzuraw changed the title Fix search app deploy Fix search-app deploy Jan 30, 2024
lkostrowski
lkostrowski reviewed Jan 30, 2024
View reviewed changes
.changeset/cuddly-stingrays-jog.md Outdated
Comment on lines 1 to 2
---
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think you need changeset. Just remove it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got CI failing because of that 🤔
CleanShot 2024-01-30 at 13 17 04@2x

https://github.com/saleor/apps/actions/runs/7708234070/job/21006898286?pr=1182

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is label for that, added

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/saleor/apps/pull/1183/files

@lkostrowski lkostrowski added the skip changeset Attach this label to PRs which does not need changes description for the release notes. label Jan 30, 2024
@lkostrowski lkostrowski self-requested a review January 30, 2024 13:04
@krzysztofzuraw krzysztofzuraw merged commit 75eb6c4 into main Jan 30, 2024
19 checks passed
@krzysztofzuraw krzysztofzuraw deleted the test-search-app branch January 30, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkostrowski lkostrowski lkostrowski approved these changes

Assignees

@krzysztofzuraw krzysztofzuraw

Labels
App: Search skip changeset Attach this label to PRs which does not need changes description for the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysztofzuraw @lkostrowski