-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vercel deploys of apps #1184
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like vercel still fails. I assume this is cause by package name change and after its rebuild, the problem will be fixed...
Scope of the PR
We discovered that the names of the packages in package.json must match the names of the folders. In the past, we had
apps/search
andname: saleor-app-search
, which caused an error during the build process with Turbo. I made the necessary changes in this pull request. Changes in sentry config are for backward compatibility. The other apps are not affected because we don't override the Vercel "Build command" for them.Stack discussion: link
Related issues
Fixes: SHOPX-107
Checklist