Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vercel deploys of apps #1184

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Fix vercel deploys of apps #1184

merged 7 commits into from
Jan 31, 2024

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Jan 31, 2024

Scope of the PR

We discovered that the names of the packages in package.json must match the names of the folders. In the past, we had apps/search and name: saleor-app-search, which caused an error during the build process with Turbo. I made the necessary changes in this pull request. Changes in sentry config are for backward compatibility. The other apps are not affected because we don't override the Vercel "Build command" for them.

Stack discussion: link

Related issues

Fixes: SHOPX-107

Checklist

Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: efb1af9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:05pm
saleor-app-crm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:05pm
saleor-app-data-importer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:05pm
saleor-app-emails-and-messages ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:05pm
saleor-app-invoices ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:05pm
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:05pm
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:05pm
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:05pm
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:05pm
saleor-app-slack ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:05pm
saleor-app-taxes ✅ Ready (Inspect) Visit Preview Jan 31, 2024 1:05pm

Copy link
Member

@lkostrowski lkostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like vercel still fails. I assume this is cause by package name change and after its rebuild, the problem will be fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants