Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup OTEL in instrumentation hook #1740

Merged
merged 39 commits into from
Feb 24, 2025
Merged

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Feb 19, 2025

Scope of the PR

  • Change package structure. After this change @saleor/apps-otel won't export withOtel wrapper but rather helpers or factories that should be used by apps to properly setup OTEL. See apps implementation on how to use new version.
  • Setup OTEL via instrumentation hook. After this change app will use official way of setting up OTEL. There are no visible changes to the end user.

Related issues

Checklist

@krzysztofzuraw krzysztofzuraw added the skip changeset Attach this label to PRs which does not need changes description for the release notes. label Feb 19, 2025
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: 94e05a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@saleor/apps-otel Major
saleor-app-products-feed Minor
saleor-app-klaviyo Minor
saleor-app-segment Minor
saleor-app-avatax Minor
saleor-app-search Minor
saleor-app-smtp Minor
saleor-app-cms Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 10:38am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
saleor-app-avatax ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 10:38am
saleor-app-cms ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 10:38am
saleor-app-klaviyo ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2025 10:38am
saleor-app-search ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 10:38am
saleor-app-segment ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 10:38am
saleor-app-smtp ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 10:38am

Copy link
Contributor

github-actions bot commented Feb 19, 2025

Differences Found

✅ No packages or licenses were added.

Summary

Expand
License Name Package Count Packages
0BSD 1
Packages
  • tslib
CC BY-SA 4.0 1
Packages
  • @cspell/dict-en-common-misspellings
CC-BY-3.0 1
Packages
  • spdx-exceptions
GPL-3.0 1
Packages
  • store2
MIT (http://mootools.net/license.txt) 1
Packages
  • slick
Public Domain 1
Packages
  • jsonify
Python-2.0 1
Packages
  • argparse
SEE LICENSE IN LICENSE.md 1
Packages
  • lightcookie
WTFPL 1
Packages
  • opener
CC-BY-4.0 2
Packages
  • @saleor/macaw-ui
  • caniuse-lite
Unlicense 2
Packages
  • @sinonjs/text-encoding
  • big-integer
BlueOak-1.0.0 3
Packages
  • jackspeak
  • package-json-from-dist
  • path-scurry
CC0-1.0 3
Packages
  • language-subtag-registry
  • spdx-license-ids
  • type-fest
<<missing>> 4
Packages
  • bruno
  • busboy
  • json-query
  • streamsearch
MPL-2.0 10
Packages
  • axe-core
  • eslint-config-turbo
  • eslint-plugin-turbo
  • turbo
  • turbo-darwin-64
  • turbo-darwin-arm64
  • turbo-linux-64
  • turbo-linux-arm64
  • turbo-windows-64
  • turbo-windows-arm64
BSD-2-Clause 31
Packages
  • @base2/pretty-print-object
  • @typescript-eslint/parser
  • @typescript-eslint/typescript-estree
  • @yarnpkg/esbuild-plugin-pnp
  • cheerio-select
  • css-select
  • css-what
  • damerau-levenshtein
  • domelementtype
  • domhandler
  • domutils
  • dotenv
  • dotenv-expand
  • entities
  • escodegen
  • eslint-scope
  • espree
  • esprima
  • esrecurse
  • estraverse
  • And 11 more...
BSD-3-Clause 53
Packages
  • @humanwhocodes/object-schema
  • @protobufjs/aspromise
  • @protobufjs/base64
  • @protobufjs/codegen
  • @protobufjs/eventemitter
  • @protobufjs/fetch
  • @protobufjs/float
  • @protobufjs/inquire
  • @protobufjs/path
  • @protobufjs/pool
  • @protobufjs/utf8
  • @saleor/eslint-plugin-saleor-app
  • @sentry/cli
  • @sentry/cli-darwin
  • @sentry/cli-linux-arm
  • @sentry/cli-linux-arm64
  • @sentry/cli-linux-i686
  • @sentry/cli-linux-x64
  • @sentry/cli-win32-i686
  • @sentry/cli-win32-x64
  • And 33 more...
ISC 72
Packages
  • @isaacs/cliui
  • @istanbuljs/load-nyc-config
  • @saleor/app-sdk
  • @ungap/structured-clone
  • abbrev
  • ansi-align
  • anymatch
  • aproba
  • are-we-there-yet
  • ast-types-flow
  • boolbase
  • c8
  • chownr
  • cli-width
  • cliui
  • color-support
  • concat-with-sourcemaps
  • console-control-strings
  • electron-to-chromium
  • eslint-import-resolver-typescript
  • And 52 more...
Apache-2.0 203
Packages
  • @ampproject/remapping
  • @aws-crypto/crc32
  • @aws-crypto/crc32c
  • @aws-crypto/ie11-detection
  • @aws-crypto/sha1-browser
  • @aws-crypto/sha256-browser
  • @aws-crypto/sha256-js
  • @aws-crypto/supports-web-crypto
  • @aws-crypto/util
  • @aws-sdk/abort-controller
  • @aws-sdk/chunked-blob-reader
  • @aws-sdk/client-dynamodb
  • @aws-sdk/client-s3
  • @aws-sdk/client-sso
  • @aws-sdk/client-sso-oidc
  • @aws-sdk/client-sts
  • @aws-sdk/config-resolver
  • @aws-sdk/core
  • @aws-sdk/credential-provider-env
  • @aws-sdk/credential-provider-http
  • And 183 more...
MIT 1671
Packages
  • @0no-co/graphql.web
  • @aashutoshrathi/word-wrap
  • @algolia/cache-browser-local-storage
  • @algolia/cache-common
  • @algolia/cache-in-memory
  • @algolia/client-account
  • @algolia/client-analytics
  • @algolia/client-common
  • @algolia/client-personalization
  • @algolia/client-search
  • @algolia/logger-common
  • @algolia/logger-console
  • @algolia/recommend
  • @algolia/requester-browser-xhr
  • @algolia/requester-common
  • @algolia/requester-node-http
  • @algolia/transporter
  • @ardatan/relay-compiler
  • @ardatan/sync-fetch
  • @arr/every
  • And 1651 more...

@vercel vercel bot temporarily deployed to Preview – saleor-app-segment February 19, 2025 09:14 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-smtp February 19, 2025 09:14 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-cms February 19, 2025 09:14 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-products-feed February 19, 2025 09:14 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-search February 19, 2025 09:14 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-klaviyo February 19, 2025 09:14 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-products-feed February 19, 2025 09:25 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-klaviyo February 19, 2025 09:25 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-smtp February 19, 2025 09:25 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-cms February 19, 2025 09:25 Inactive
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 17.27273% with 364 lines in your changes missing coverage. Please review.

Project coverage is 44.03%. Comparing base (6067b94) to head (94e05a5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apps/segment/src/pages/api/manifest.ts 0.00% 30 Missing ⚠️
apps/avatax/src/otel-instrumentation.node.ts 0.00% 24 Missing and 1 partial ⚠️
apps/segment/src/otel-instrumentation.node.ts 0.00% 24 Missing and 1 partial ⚠️
apps/cms/src/otel-instrumentation.node.ts 0.00% 22 Missing and 1 partial ⚠️
...pps/products-feed/src/otel-instrumentation.node.ts 0.00% 22 Missing and 1 partial ⚠️
apps/search/src/otel-instrumentation.node.ts 0.00% 22 Missing and 1 partial ⚠️
apps/smtp/src/otel-instrumentation.node.ts 0.00% 22 Missing and 1 partial ⚠️
apps/segment/src/pages/api/register.ts 0.00% 16 Missing ⚠️
apps/segment/next.config.js 0.00% 12 Missing ⚠️
apps/avatax/src/instrumentation.ts 0.00% 7 Missing and 1 partial ⚠️
... and 54 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
- Coverage   44.05%   44.03%   -0.02%     
==========================================
  Files         643      661      +18     
  Lines      296108   296318     +210     
  Branches     2003     2016      +13     
==========================================
+ Hits       130458   130494      +36     
- Misses     165244   165405     +161     
- Partials      406      419      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krzysztofzuraw krzysztofzuraw removed the skip changeset Attach this label to PRs which does not need changes description for the release notes. label Feb 24, 2025
@krzysztofzuraw krzysztofzuraw changed the title WIP: setup OTEL in instrumentation hook Setup OTEL in instrumentation hook Feb 24, 2025
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review February 24, 2025 10:41
@krzysztofzuraw krzysztofzuraw requested a review from a team as a code owner February 24, 2025 10:41
@krzysztofzuraw krzysztofzuraw merged commit 3c4358a into main Feb 24, 2025
35 of 40 checks passed
@krzysztofzuraw krzysztofzuraw deleted the otel-instrumention-hook branch February 24, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants