Add AWS instrumentation for DynamoDB and disable HTTP instrumentation for Sentry requests #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Sentry requests
🦋 Changeset detectedLatest commit: 3691b21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
krzysztofzuraw
commented
Mar 6, 2025
| @@ -4,7 +4,6 @@ export const createHttpInstrumentation = () => { | |||
| return new HttpInstrumentation({ | |||
| requireParentforIncomingSpans: true, | |||
| requireParentforOutgoingSpans: true, | |||
| ignoreOutgoingRequestHook: (request) => | |||
| request.hostname === "ingest.sentry.io" || request.path === "/v1/logs", | |||
There was a problem hiding this comment.
we no longer use logs from OTEL and integration already disables calls to v1/traces / v1/metrics etc
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1758 +/- ##
==========================================
- Coverage 44.01% 44.01% -0.01%
==========================================
Files 661 661
Lines 295941 295943 +2
Branches 2010 2010
==========================================
Hits 130258 130258
- Misses 165263 165265 +2
Partials 420 420 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Differences FoundExpandLicense Package <<missing>> browser-assert <<missing>> eval <<missing>> require-like <<missing>> year Apache-2.0 @opentelemetry/instrumentation-aws-sdk Apache-2.0 @opentelemetry/propagation-utils SummaryExpand
|
lkostrowski
reviewed
Mar 6, 2025
|
|
||
| export const createAwsInstrumentation = () => { | ||
| return new AwsInstrumentation({ | ||
| suppressInternalInstrumentation: true, |
There was a problem hiding this comment.
what does it mean? can you add comment?
There was a problem hiding this comment.
Done in 3691b21 (#1758)
lkostrowski
previously approved these changes
Mar 6, 2025
lkostrowski
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the PR
AwsInstrumentationfactory that can be used to auto instrument DynamoDB calls.Related issues
Checklist