Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AvaTax client to use nevethrow #1764

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Mar 11, 2025

Scope of the PR

  • Refactored AvaTax client to use nevethrow - thanks to that it will be easier to wrap AvaTax methods with custom spans and set span statuses based on response.

Related issues

Checklist

Copy link

changeset-bot bot commented Mar 11, 2025

🦋 Changeset detected

Latest commit: a7d7c92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-app-avatax Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 1:15pm
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 1:15pm
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 1:15pm
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 1:15pm
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 1:15pm
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 1:15pm
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 1:15pm

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 31.48148% with 111 lines in your changes missing coverage. Please review.

Project coverage is 44.00%. Comparing base (a692b25) to head (a7d7c92).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apps/avatax/src/modules/avatax/avatax-client.ts 9.33% 68 Missing ⚠️
.../order-confirmed/avatax-order-confirmed-adapter.ts 0.00% 12 Missing ⚠️
.../calculate-taxes/avatax-calculate-taxes-adapter.ts 65.00% 7 Missing ⚠️
.../avatax/src/modules/avatax/avatax-errors-parser.ts 33.33% 6 Missing ⚠️
...ax/configuration/avatax-auth-validation.service.ts 0.00% 6 Missing ⚠️
...c/modules/avatax/avatax-client-tax-code.service.ts 77.77% 4 Missing ⚠️
...odules/avatax/tax-code/avatax-tax-codes.service.ts 0.00% 4 Missing ⚠️
...x/src/modules/avatax/avatax-entity-type-matcher.ts 66.66% 2 Missing ⚠️
...configuration/avatax-address-validation.service.ts 0.00% 1 Missing ⚠️
.../order-cancelled/avatax-order-cancelled-adapter.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1764      +/-   ##
==========================================
- Coverage   44.01%   44.00%   -0.02%     
==========================================
  Files         661      661              
  Lines      295943   295957      +14     
  Branches     2010     2009       -1     
==========================================
- Hits       130258   130228      -30     
- Misses     165265   165309      +44     
  Partials      420      420              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@krzysztofzuraw krzysztofzuraw merged commit c51307e into main Mar 12, 2025
29 checks passed
@krzysztofzuraw krzysztofzuraw deleted the prod-130-refactor-avatax-calls branch March 12, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants