Add regression test for salsa-rs#455 #740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
force-pushed
the
veykril/push-pqrtwzpuqtkw
branch
from
b7aa826 to
8686c47
Compare
✅ Deploy Preview for salsa-rs canceled.
|
✅ Deploy Preview for salsa-rs canceled.
|
Veykril
changed the title
|
@carljm might be good to check if this is fixed in your PR (feel free to pick the test over to your branch) |
CodSpeed Performance ReportMerging #740 will not alter performanceComparing Summary
|
|
This test behaves as expected under fixpoint iteration cycle handling in #603. I went ahead and committed a slightly-modified version (that doesn't iterate forever) in that branch. I think this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #455, this still fails today but with a different panic. Given recovery is involved this might be fixed by the fixpoint changes