Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #1470: upgrade eslint #1472

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Close #1470: upgrade eslint #1472

merged 1 commit into from
Jan 27, 2025

Conversation

samchon
Copy link
Owner

@samchon samchon commented Jan 27, 2025

eslint has been changed a lot, so hard to follow it up.

Can you review this one? @ryoppippi


This pull request includes several updates to dependencies and configuration files to improve the project's setup and ensure compatibility with the latest tools and libraries. The most important changes include updating dependencies in package.json, renaming and modifying the ESLint configuration file, and adjusting ESLint scripts.

Dependency Updates:

  • Updated @samchon/openapi dependency version range to ">=2.4.0 <3.0.0" in package.json.
  • Updated @typescript-eslint/eslint-plugin and @typescript-eslint/parser to version "^8.1.0" in package.json.
  • Added eslint-plugin-deprecation version "^3.0.0" to package.json.

Configuration Changes:

  • Renamed .eslintrc.cjs to eslint.config.cjs and added deprecation plugin to the ESLint configuration.
  • Modified ESLint rules in eslint.config.cjs to disable certain rules and reorder file patterns.

Script Adjustments:

  • Simplified ESLint scripts in package.json to remove file patterns from the command.

@samchon samchon added the enhancement New feature or request label Jan 27, 2025
@samchon samchon self-assigned this Jan 27, 2025
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@fastify/[email protected] None 0 25.5 kB matteo.collina
npm/@sinclair/[email protected] None 0 536 kB sinclair
npm/@trivago/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +62 20.3 MB ayusharma
npm/@typegoose/[email protected] environment Transitive: eval, filesystem, network +99 15.6 MB hasezoey
npm/@types/[email protected] None 0 21.9 kB types
npm/@types/[email protected] None 0 9.24 kB types
npm/@types/[email protected] None 0 3.23 kB types
npm/@types/[email protected] None 0 6.67 kB types
npm/[email protected] environment, filesystem, network, shell Transitive: eval, unsafe +32 2.88 MB matteo.collina
npm/[email protected] eval +1 138 kB jdalton
npm/[email protected] None 0 776 kB typestack-release-bot
npm/[email protected] None +3 14.3 MB typestack-release-bot
npm/[email protected] 🔁 npm/[email protected] Transitive: filesystem, network, shell +33 3.64 MB mbostock
npm/[email protected] environment, filesystem, network Transitive: eval, unsafe +59 1.62 MB jonchurch
npm/[email protected] eval +5 622 kB jsumners
npm/[email protected] Transitive: environment, eval, filesystem +39 4.99 MB eomm
npm/[email protected] None +1 5.2 MB gcanti
npm/[email protected] eval, filesystem, network, shell, unsafe Transitive: environment +49 8.8 MB domenic
npm/[email protected] None 0 176 kB pieroxy
npm/[email protected] shell 0 3.14 kB seb
npm/[email protected] environment, filesystem, unsafe 0 11.2 MB prettier-bot
npm/[email protected] None 0 15.3 kB cwmma
npm/[email protected] None 0 295 kB rbuckton
npm/[email protected] Transitive: network +6 3 MB samchon
npm/[email protected] None 0 0 B

🚮 Removed packages: npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@monaco-editor/[email protected], npm/@mui/[email protected], npm/@mui/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rspack/[email protected], npm/@rspack/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/@babel/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

pkg-pr-new bot commented Jan 27, 2025

Open in Stackblitz

npm i https://pkg.pr.new/typia@1472

commit: 15b780e

Copy link
Contributor

@ryoppippi ryoppippi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flat config is fine!
LGTM.

@ryoppippi
Copy link
Contributor

@samchon maybe we can add lint/format check in github actions

@samchon
Copy link
Owner Author

samchon commented Jan 27, 2025

OK, about the github actions eslint filtering, I'll wait your PR. Thanks for reviewing.

@samchon samchon merged commit 1ded23f into master Jan 27, 2025
9 checks passed
@samchon samchon deleted the dependencies/eslint branch January 28, 2025 14:57
@ryoppippi
Copy link
Contributor

@samchon I found that eslint config is wrong, I'm sorry.
I'll create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants