Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GitHub Actions CI workflow for code quality #1480

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

ryoppippi
Copy link
Contributor

This pull request introduces a new CI workflow and updates the package.json scripts to improve code formatting checks.

CI Workflow:

  • .github/workflows/ci.yml: Added a new CI workflow configuration that runs on push and pull request events. It includes steps to check out the code, set up Node.js, install dependencies, and run eslint and prettier checks.

Code Formatting:

  • package.json: Updated the prettier script to use the --check option and added a new prettier:fix script to format the code.
  • package.json: Added a newline at the end of the file for consistency.

Add GitHub Actions workflow for running ESLint and Prettier checks on push and
pull requests. Update prettier npm scripts to separate check and fix commands.
Copy link

pkg-pr-new bot commented Feb 2, 2025

Open in Stackblitz

npm i https://pkg.pr.new/typia@1480

commit: 5b99d41

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would better to add the npm run eslint command on the build.yml.

@ryoppippi
Copy link
Contributor Author

@samchon OK got it

@ryoppippi ryoppippi requested a review from samchon February 3, 2025 10:26
Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution.

@samchon samchon merged commit c9780a9 into samchon:master Feb 3, 2025
10 checks passed
@ryoppippi ryoppippi deleted the feature/ci branch February 3, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants