rollup fix #1527
Merged
rollup fix #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryoppippi
commented
Mar 1, 2025
ryoppippi
commented
- modify rollup config to generate submodules in esm format
- add .js prefix to @samchon/openapi because in esm we need to add extension when we import scripts
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
commit: |
ryoppippi
force-pushed
the
feature/rollup-fix
branch
from
33a6082 to
b0d1717
Compare
|
@samchon I'l| write |
This reverts commit b0d1717.
Resolves import issues with @samchon/openapi by automatically adding .mjs extension to import statements and external module resolution. This ensures proper module loading in ESM environments.
|
fixed! Please check the output file using |
ryoppippi
commented
Mar 1, 2025
| const ext = `mjs`; | ||
| const nodeModulesDir = `node_modules`; | ||
| if (chunkInfo.name.includes(nodeModulesDir)) { | ||
| throw new Error(`Invalid chunk name: ${chunkInfo.name}`); |
There was a problem hiding this comment.
all dependencies are now external.
ryoppippi
commented
Mar 1, 2025
Comment on lines
+27
to
+45
| { | ||
| name: "add-js-to-samchon-openapi", | ||
| renderChunk(code) { | ||
| return code.replace(/import (.+) from "(.+)"/g, (m, m1, m2) => { | ||
| if(m2.startWith('@samchon/openapi/lib')) { | ||
| return `import ${m1} from "${m2}.mjs"` | ||
| } | ||
| return m; | ||
| }) | ||
| }, | ||
| resolveId(id) { | ||
| if (id.startsWith("@samchon/openapi/lib")) { | ||
| return { | ||
| id: id + ".mjs", | ||
| external: true, | ||
| } | ||
| } | ||
| }, | ||
| }, |
There was a problem hiding this comment.
convert @samchon/openapi/lib/~~ to @samchon/openapi/lib/~~.mjs
|
@samchon this resolves esm modules so please check it |
samchon
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.