Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade instructions from Postgresql 12 to 14 #2854

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

froque
Copy link
Contributor

@froque froque commented Nov 4, 2023

Postgres 15 has a permissions problem.
See sameersbn/docker-postgresql#168

@froque froque force-pushed the upgrade_postgres_instructions branch from 94231a0 to 0db1870 Compare November 4, 2023 13:28
@froque froque changed the title Upgrade instructions form Postgresql 12 to 14 Upgrade instructions from Postgresql 12 to 14 Nov 4, 2023
@kkimurak
Copy link
Contributor

kkimurak commented Nov 9, 2023

Test seems fail because of refused connection but there seems to be no problem with the gitlab container. In the test, docker ps is executed after docker compose up, but at this point the state of the sameersbn/postgresql container is "Restarting (1) Less than a second ago", and it may be stuck in a restart loop.

Local test on my environment (to follow circle ci step) worked - web interface open, login and creating new blank project succeed.

Could you please try restarting CI (by rebase and force-push, or something else)?

@froque froque force-pushed the upgrade_postgres_instructions branch from 0db1870 to 4fe8140 Compare November 9, 2023 11:26
@froque froque force-pushed the upgrade_postgres_instructions branch from 4fe8140 to c814fb7 Compare November 9, 2023 11:54
@froque
Copy link
Contributor Author

froque commented Nov 9, 2023

@kkimurak postgres 14 was failling in circle ci with

�[33mpostgresql_1  |�[0m popen failure: Cannot allocate memory
�[33mpostgresql_1  |�[0m initdb: error: The program "postgres" is needed by initdb but was not found in the
�[33mpostgresql_1  |�[0m same directory as "/usr/lib/postgresql/14/bin/initdb".

upgrading to latest ubuntu resolves the problem
https://stackoverflow.com/a/77078191/3929185

@kkimurak
Copy link
Contributor

kkimurak commented Nov 9, 2023

@froque Ok build and test passed. Thank you for your work.
Please so be kind to wait for maintainer review,


note:
link to docker log when the postgres14 container was failing : https://app.circleci.com/pipelines/github/sameersbn/docker-gitlab/1316/workflows/db562f70-d7e2-498f-986b-3da600bcfb51/jobs/6155?invite=true#step-108-1433_39

@sachilles
Copy link
Collaborator

Hi,

regarding this PR I'd like to clarify some things.

Postgres 15 has a permissions problem. See sameersbn/docker-postgresql#168

Since I'm running GitLab from this repo with PostgreSQL 15.4, I can't confirm that PostgreSQL has some issues. However, it's a long time ago that I had to restore from backup.

Copy link
Collaborator

@sachilles sachilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachilles sachilles merged commit 2f5b097 into sameersbn:master Nov 19, 2023
@froque froque deleted the upgrade_postgres_instructions branch January 3, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants