Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZipFile to REQUIRE #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohamed82008
Copy link

No description provided.

@samoconnor
Copy link
Owner

Thanks for this @mohamed82008,

I've asked about what the best way to handle this is on #pkg-usage on Slack:

InfoZip.jl has no listed dependencies in REQUIRE. It uses system installed InfoZip binaries zip and unizip if it can find them. If there is no local InfoZIP, the ZipFile.jl module is used as a (functional but much slower) backend.
A user as submitted a PR asking to put InfoZip int REQUIRE #13
I would rather not pull in InfoZIP.jl in builds where I’m trying to keep size minimal (e.g. AWSLambda deployment).

Is there a way in Pkg3 to express “Requires system installed infozip …or… InfoZIP.jl” ?
Or, so say: “Requires InfoZIP.jl on Windows, but not on mac or unix” ?

@samoconnor
Copy link
Owner

@samoconnor
Copy link
Owner

... and @aviks suggested that there is a way to make the "requires InfoZIP.jl" a windows-only thing.
https://julialang.slack.com/archives/C67EFTEF3/p1538481105000100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants