✨ (JS syntax enhancment) Some JS syntax enhancment #12
Conversation
Function declaration & call is no longer white and is now orange. Class instanciation is now blue according to PHP screenshot Closes samrap#4
|
Stumbled upon this theme today and really like it but also felt the JS syntax highlighting could use a bit of work, so was pleased to see someone taking up the challenge! 😄 |
|
Thanks ! I tried to stay as close as possible to the original PHP syntax for the object literal keys, so that's why i left them white for now. |
|
@hhochart29 You looking to fork the theme then? |
|
I did a fork and tried today to put my version on the marketplace but didn't seem to work. will give another try ! |
|
@hhochart29 I'll look out for it as I'd definitely like to see a version of this theme go forward but with better JS syntax support. |
|
There you go @sr-scott |
|
Whoop! I'll move further discussion to your repo then :) |
|
@hhochart29 throwing this here as your repo doesn't appear to have issues enabled and upstream looks unmaintained -- any way you'd consider also publishing this to the Open VSX registry? It would make this accessible to downstream projects like Theia and VSCodium, which can't access the VS Code Marketplace for licensing reasons. (In particular, various Arch Linux distros ship with Code-OSS builds by default.) Here's a link to some relevant documentation from the OVSX wiki. |
|
Hi @chaosharmonic , i've opened issues on my own fork. I'll take a look about publishing to OVSX. I'm quite busy atm but i'll look at this whenever i have few minutes :) thanks |
#4 Related (still WIP)