Explicit layout and fix dense tensor printing #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ntjohnson1 Sorry, I did not fix the merge conflicts correctly after the auto-merge of main into your branch. I tried to make the changes in a Codespace on your fork, but it did not let me push to your branch. I got confused about the state of the updates, as the conflicts had partial fixes for Can you please fix this when you get a chence? |
ntjohnson1
force-pushed
the
nick/layout
branch
from
cd4dcaf to
2471d51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #338 and also makes progress towards being more explicit/consistent about our Fortran formatting discussed here and here
We probably want to capture the fortran ordering in our documentation somewhere and I should probably open an issue to make the ordering flow throughout pyttb so we can eventually support "C" ordering as well.
📚 Documentation preview 📚: https://pyttb--354.org.readthedocs.build/en/354/