Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

363 example tensor for cp als needs to have cp structure #392

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dmdunla
Copy link
Collaborator

@dmdunla dmdunla commented Feb 5, 2025

@tgkolda Can you review this PR, which addresses #363 ?


📚 Documentation preview 📚: https://pyttb--392.org.readthedocs.build/en/392/

@dmdunla dmdunla requested a review from tgkolda February 5, 2025 05:45
@dmdunla dmdunla linked an issue Feb 5, 2025 that may be closed by this pull request
@dmdunla
Copy link
Collaborator Author

dmdunla commented Feb 5, 2025

Note that this only changes the tutorial for cp_als. Once this looks good, we should make changes for other algorithms to use low-rank tensors as input. Currently, the tutorials were aimed at replication of the MATLAB TTB tutorials, except that loaded data was replaced with generated data. So, this should be revisited to improve consistency across the tutorials.

@tgkolda
Copy link
Collaborator

tgkolda commented Feb 5, 2025

Hi @dmdunla, This is a bad example because it takes too long to converge. Using normal random values rather than uniform for factor matrices accelerates the convergence and should obviate the need to the limit of iterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example tensor for cp_als needs to have CP structure
2 participants