feat(check-eslint): Check for ESLint peerDependency being met #290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before anything else, checks that ESLint is installed and present in a sufficient version, exit with code 1 otherwise.
This is currently wip — I just threw it together this evening and wanted to collect some opinions.
There are some minor issues reported by the linter: almost the whole content of
bin/diff.js
moved into the eslint-check's else-branch and with it all the function declarations. I think that whole thing should be refactored soon anyways, so I'd think it's not that big of a deal ...I planned to make use of
yargs
feature to print out usage instructions too (in case of insufficient arguments), but that would be out of scope for this PR.PS: If not already known, appending
?w=0
to the url for the commits of this PR (like here) ignores whitespace changes and makes this PR much more easy to read.