Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<tab> touch completion not work with SAS code #45

Closed
pascalou3 opened this issue Oct 13, 2017 · 3 comments
Closed

<tab> touch completion not work with SAS code #45

pascalou3 opened this issue Oct 13, 2017 · 3 comments

Comments

@pascalou3
Copy link

Hi,
when we try to use completion function to ask SAS code sugestion, it doesn't work correctly.
=> With SAS PROC, you haven't suggestion on options.
PROC SORT DA => Jupyter NB doesn't suggest DATA option.
=> With Data step, the suggestion only is you writes a correct statement before.
DATA T ;
SE => Jupyter NB doesn't suggest statement. It suggest only if you write SET completly.
I attach a doc with my tests and associated kernal error.
Regards,
pascal
Jupyter_Notebook_SAS-Kernel-UI-problem.docx

@jld23
Copy link
Contributor

jld23 commented Oct 25, 2017

I see this issue in the current code base, I'm not sure the cause yet but I'm looking into it.

Jared

tomweber-sas added a commit that referenced this issue Dec 1, 2022
tomweber-sas added a commit that referenced this issue Dec 1, 2022
@tomweber-sas
Copy link
Collaborator

This was never fixed, and Jared isn't at SAS anymore. So, I've looked at this and pushed a fix. I haven't worked on this code in a long time, so I still had master instead of main which is why I first pushed to master. I've removed that branch since main is the only right one to have out here. I'll try to figure out how to publish this in a new release. I've never done that with this repo before.

@tomweber-sas
Copy link
Collaborator

Ok, there's a new release, 2.4.13 both here and on PyPI. All (both?) of the issues in the doc that was linked in here work, and I see no more errors trying the tab complete now. I'll close this, let me know if you find any other issues.
Thanks,
Tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants