-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FindMarkers w/ MAST returns error after Seurat SCTransform, v2 regularization #6489
Comments
Having this same issue! |
Sorry, no solution on my end. Hoping maybe the bug fix will be incorporated in the next Seurat release? |
Same issue for me too! |
It used to run fine for me with the SCT v2 data. I definitely think there's something up on the Seurat end because I also get a warning (not error though so it still runs) about norm.method not being used when I run other tests, even though I don't supply norm.method in my code. |
Hi @AmyRossi , Do you recall which version of Seurat you used successfully run SCT v2 + MAST ? Thanks! |
@grhogg It looks like the latest release was back in May but I've definitely successfully run it as recent as mid-September ... Unfortunately, I don't know if I just hadn't updated my Seurat at that point ? Do you know if there's a way for me to figure out the last time I updated it? I don't understand enough about packages to troubleshoot where the apparently-new issue stems from... |
Ohh nevermind, it looks like 4.2 was pushed out on 09-20-22? If I'm looking in the right place this time? So I must've used the version prior to this one when it worked |
Awesome! That is extremely helpful. I will try with the previous version, and let you know if it works :) |
I had the same error and installing an older version of Seurat resolved it for me. I previously had Seurat 4.2, but installed Seurat 4.1.1 then everything began to work normally again. #just to check what version you are actually using library(remotes) remotes::install_version("Seurat", version = "4.1.1") |
Awesome, thank you @MadsE10 ! |
I'm having this problem... has anyone found another solution? I've changed Seurat versions a few times, to to v4.1.1 and now to Dev, but those changes didn't help. All packages up to date and FindMarkers works if I use a different method OR change assay to RNA.... but I want to use MAST on SCTv2-normalized data, if at all possible.
If I add norm.method parameter to above FindMarkers command, this error is returned:
So it seems that there is an error with how Seurat's FindMarkers function is interacting with MAST. Many thanks for any advice on how to proceed. Session Info:
|
Any updates or assistance available on this issue? Many thanks. |
Norm.method pamameter is not valid. I have changed the R script for this. Please see https://github.com/weixiao1991/seurat. |
Hi Weixiao1991. Thank you for helping. I tried again today with Development version and also with a clean installation of Seurat version 4.3.0 from CRAN, but the issue persists. Any idea what is going on? Note that my object is a subset of the initial integration. However I am able to run FindMarkers with the default test, and can convert my Seurat object to an SCE object to run with MAST. But it would be much preferable to run directly via Seurat for a variety of reasons.
results in:
Session Info:
|
Hi. |
Hi all! I had the same error when trying to use the function with SCT data. What works for me is to start from the RNA assay and raw counts and normalize using NormalizeData instead of SCT.
It runs smoothly for me. EDIT:
|
Hi @weixiao1991, I'm trying to run it on integrated data and I made sure to run |
|
If you delete SCT.model list from the seurat object, it suddenly works. I could remove it by: sne[["LOL"]] <- CreateAssayObject(counts = GetAssayData(sne, assay="SCT", slot="data")) #Copy "SCT data" to "LOL counts" and "LOL data" |
Does anyone know if this bug was fixed in Seurat v5? |
This bug was fixed with the most recent push of MAST. Download mast directly from GitHub, not from bioconductor. |
Oh, thanks a lot! :) |
Hi, I was having the same issue while trying to run MAST using a SCT normalized assay. I managed to solve it by using what was described by @nvribeiro. |
Hello,
Thank you for everything you do! Seurat is amazing!
I have been running into an error when trying to run FindMarkers on a Seurat Object with the MAST algorithm, using their newer v2 regularization pipeline. Any help would be greatly appreciated.
error is generated after calling MAST in findmarkers. Other tests like Wilcox still work fine
R base 4.2.1
Seurat version 4.2
Mast version 1.22
SCTransform version 0.3.5
Example with Seurat Dataset:
traceback()
The text was updated successfully, but these errors were encountered: