This repository was archived by the owner on Sep 19, 2021. It is now read-only.
Scheduling requirements are back to bundle.conf #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scheduling requirements are now back to bundle.conf as they are a developer concern, not an operator's. In addition the memory declaration is applied to a bundle component's mx and mm parameters, otherwise sbt-native-packager will insist that these values should be 1GB. 1GB is excessive for running lots of small things on ConductR.
huntc
force-pushed
the
internalise-scheduling
branch
from
57e62ef to
2e46f46
Compare
|
LGTM |
hseeberger
added a commit
that referenced
this pull request
Mar 2, 2015
Scheduling requirements are back to bundle.conf
| components = { | ||
| "angular-seed-play-1.0-SNAPSHOT" = { | ||
| description = "angular-seed-play" | ||
| file-system-type = "universal" | ||
| start-command = ["angular-seed-play-1.0-SNAPSHOT/bin/angular-seed-play"] | ||
| start-command = ["angular-seed-play-1.0-SNAPSHOT/bin/angular-seed-play", "-Xmm=67108864", "-Xmx=67108864"] |
There was a problem hiding this comment.
I am hoping memory settings can be managed by sbt-native-manager when sbt/sbt-native-packager#510 gets merged.
|
LGTM |
|
I'm working on the default settings. First step was to be able to specify the javaOptions via build.sbt . next will be the removal of our defaults. |
|
Thanks @muuki88 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scheduling requirements are now back to
bundle.confas they are a developer concern, not an operator's. In addition the memory declaration is applied to a bundle component's mx and mm parameters, otherwise sbt-native-packager will insist that these values should be 1GB. 1GB is excessive for running lots of small things on ConductR.Also updated to the latest sbt-native-packager (
1.0.0-RC1).