-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"/etc/default/<package-name>" should be shell script setting envars #472
Comments
From Debian Policy Manual
|
Hmm.. Seems that during refactoring we missed this. We should source /etc/default/app_name in init script. |
@dhardy92, PR is welcome! |
[fix #472] /etc/default/<package-name> should be shell script setting envars
Revert "[fix #472] /etc/default/<package-name> should be shell script se...
* master: Update README.md Replace chmod call More comprehensive tests Adding documentation FIX sbt#276 creating directories as necessary and specify top level dir and sadly realizing that apache commons compress is still the best bet Adding documentation, examples and tests. Initial refactoring on sbt#453 Revert "[fix sbt#472] /etc/default/<package-name> should be shell script setting envars" FIX sbt#489: Small fix in documentation Upgrading to java 7 and using posix nio API Conflicts: src/main/scala/com/typesafe/sbt/packager/jdkpackager/JDKPackagerHelper.scala
Hello everyone, why was this reverted? |
See #491 |
This bug should be re-opened, since the /etc/default/ script is still not getting sourced. |
@jasonmartens can you open a new issue with a small sample project demonstrating the case? |
Current format is java option only append to java command line.
This is not standards and not very flexible and expendable.
Shell let us include other source and split config in several files and responsibilities using
source
Moreover, envars usage is a 12-factors app recommendation.
The text was updated successfully, but these errors were encountered: