Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for jdkPackagerTool is computed incorrectly on Windows. #495

Closed
metasim opened this issue Feb 16, 2015 · 7 comments
Closed

Comments

@metasim
Copy link
Member

metasim commented Feb 16, 2015

The locateJDKPackagerTool() did work on windows, I had to set the setting with:

jdkPackagerTool := Some(file("C:\\Program Files\\Java\\jdk1.8.0_31\\bin\\javapackager.exe"))
@metasim
Copy link
Member Author

metasim commented Feb 16, 2015

I plan on working on this one.

@metasim
Copy link
Member Author

metasim commented Feb 16, 2015

Issue appears to be that under windows, a separate JRE is installed with the JDK, and the JRE java is in the PATH before the JDK java. Therefore, when SBT runs, by default, it runs under the JRE and not the JDK. Looking into way of either a) getting the JDK path from some other SBT setting, or b) figuring out the path to the JDK from the JRE with minimal hackishness.

@metasim
Copy link
Member Author

metasim commented Feb 16, 2015

Also forgot about Windows executables having the (hidden) ".exe" extension.

metasim pushed a commit to metasim/sbt-native-packager that referenced this issue Feb 16, 2015
… SBT

is running in the parallel installed JRE.
@metasim
Copy link
Member Author

metasim commented Feb 16, 2015

Pull request submitted.

@metasim metasim closed this as completed Feb 16, 2015
@muuki88
Copy link
Contributor

muuki88 commented Feb 16, 2015

@metasim , if you include FIX #issuenumber (which you did) in the commit the issue gets closed automatically if the pr is merged :)

@metasim
Copy link
Member Author

metasim commented Feb 16, 2015

@muuki88 Thanks for the tip. Was my mistake that "Fix" wasn't all caps? Or that I just needed to wait for the PR process to finish?

@muuki88
Copy link
Contributor

muuki88 commented Feb 16, 2015

I think that should matter. The pr just hasn't been merged yet :)

muuki88 added a commit that referenced this issue Feb 20, 2015
Fix #495. Enhanced `locateJDKPackagerTool` to work on Windows when SBT...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants