Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstart script does not use killTimeout #754

Closed
elm- opened this issue Mar 14, 2016 · 3 comments
Closed

Upstart script does not use killTimeout #754

elm- opened this issue Mar 14, 2016 · 3 comments

Comments

@elm-
Copy link

elm- commented Mar 14, 2016

We are using upstart on ubuntu and the default kill timeout of 5 seconds is not overwritten by setting of LinuxKeys.killTimeout in the settings. I checked the template and it does not contain the relevant placeholder. is there a reason or can this be added?

@muuki88
Copy link
Contributor

muuki88 commented Mar 15, 2016

Thanks for your feature request @elm-

There is no reason for that. It wasn't simply implemented. If you could create a small PR adding this, would be awesome :)

@elm-
Copy link
Author

elm- commented Jun 10, 2016

@muuki88 thanks a lot, sorry I actually missed your comment to provide a pull request, I would have done that otherwise.

@muuki88
Copy link
Contributor

muuki88 commented Jun 10, 2016

No problem. We made some bigger changes to the systemloader feature, which makes a a lot easier now to integrate such specific changes.

There will always be a next time for a pull request :) For instance #770 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants