Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for multi-module builds #1088

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Conversation

nornagon
Copy link
Contributor

@nornagon nornagon commented Jan 4, 2018

The packageArchetype.java_server syntax is deprecated and broken.

Probably the example should also be updated.

The `packageArchetype.java_server` syntax is deprecated and broken.
@lightbend-cla-validator
Copy link

Hi @nornagon,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@muuki88
Copy link
Contributor

muuki88 commented Jan 4, 2018

Thanks a lot 😍

@muuki88 muuki88 merged commit 81a3d5b into sbt:gh-pages Jan 4, 2018
@nornagon nornagon deleted the patch-2 branch January 5, 2018 01:52
@nornagon
Copy link
Contributor Author

nornagon commented Jan 5, 2018

No problem! I signed the CLA, too. Should I make a PR for the example repo too?

nornagon added a commit to nornagon/sbt-native-packager-examples that referenced this pull request Jan 5, 2018
The package archetype syntax is deprecated and broken.

See also sbt/sbt-native-packager#1088
@nornagon
Copy link
Contributor Author

nornagon commented Jan 5, 2018

It was easy so I just did it :)

muuki88 pushed a commit to muuki88/sbt-native-packager-examples that referenced this pull request Jan 5, 2018
The package archetype syntax is deprecated and broken.

See also sbt/sbt-native-packager#1088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants