-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for native-image to work in Windows #1312
Conversation
* The final native-image executable cannot be located in the file native-image.cmd unless the full path to native-image.cmd is given. Therefore, a new parameter is provided to the user to specify the native-image.cmd location. * Picks the right CLASSPATH separator according to the OS instead of hardcoded to colon. Using Colon will fail in Windows build. * Tested against GraalVM 20.0.0 and VS 2019.
Hi @sshark, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
src/main/scala/com/typesafe/sbt/packager/graalvmnativeimage/GraalVMNativeImagePlugin.scala
Outdated
Show resolved
Hide resolved
…aalVMNativeImagePlugin.scala Co-Authored-By: nigredo-tori <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the very well done pull request ❤️
A small remark that would be nice if you could fix it 😄
src/main/scala/com/typesafe/sbt/packager/graalvmnativeimage/GraalVMNativeImageKeys.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix ❤️ I'll merge this as soon as the checks are green.
This might be too much to ask, but since windows users are rare 😄
If you have time and interest in helping to fix the windows build that would be awesome.
However don't feel pressured or anything. I just wanted to ask 😃
The appveyor build started to fail for no reasons a month ago. It started with #1299 which didn't change any windows related stuff.
Example: https://ci.appveyor.com/project/muuki88/sbt-native-packager/builds/31212944
[info] [error] > call set _PARAM1=%1
[info] [error] error < > was unexpected at this time.
[info] [error]
[info] [error] > set "_TEST_PARAM=\"-Dtest.hoge=\[]!< >%\""
[info] [error] Total time: 13 s, completed Mar 3, 2020 4:15:24 PM
[error] x windows / test-bat-template
[error] Cause of test exception: {line 4} Command failed: checkScript failed
Running windows / test-custom-main
[error] java.lang.RuntimeException: Failed tests:
[error] windows / test-bat-template
[error]
I can't make any sense from the error message. So if you can and have an idea how to fix this, I would be suuuuper happy 😍
Let me take a shot at it over the weekend and see if I can make sense out of those error messages. I am not a Windows developer either. For me, Windows is just a means to an end 🤐 😃 |
Even more thanks then 😍 |
native-image.cmd unless the full path to native-image.cmd is
given. Therefore, a new parameter is provided to the user to
specify the native-image.cmd location.
instead of hardcoded to colon. Using Colon will fail in Windows
build.