FIX #239. Start run levels, dependencies in upstart and systemV impl #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kardapoltsev
changed the title
|
Unfortunately I can't test in on upstart system now. |
|
Also, since in Upstart we could write smth like this may be it'll be better to convert What do you think? |
|
I think a string is a better option. I have no idea how |
|
Yes, I'm also thinking about support of systemd) I'll change things to strings today. |
|
LGTM |
muuki88
added a commit
that referenced
this pull request
May 14, 2014
FIX #239. Start run levels, dependencies in upstart and systemV impl
| @@ -9,10 +9,12 @@ author "${{author}}" | |||
| # See a list of stanzas here: http://upstart.ubuntu.com/wiki/Stanzas#respawn | |||
|
|
|||
| # When to start the service | |||
| start on runlevel [2345] | |||
| start on runlevel [${{start_runlevels}}] | |||
| start on started (${{start_facilities}}) | |||
There was a problem hiding this comment.
The round brackets causing an error, so upstart doesn't work. We need [${{start_facilities}}]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.