Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for -javaagent parameters. #265

Closed
wants to merge 1 commit into from

Conversation

jlandahl
Copy link

This change ensures that "-javaagent:" parameters get passed to the JVM correctly. Previously they ended up as arguments to the main class rather than the JVM and consequently did not work.

@muuki88
Copy link
Contributor

muuki88 commented May 24, 2014

Thanks, but I think there's no need for that. You should be able to add these parameters with a -J prefix. In your case

-J-javaagent

@muuki88
Copy link
Contributor

muuki88 commented May 30, 2014

@jlandahl , did my suggested solution work for you? If so, I close this pr. Thanks anyway :)

@muuki88 muuki88 added rpm and removed bug labels Jun 6, 2014
@muuki88 muuki88 added this to the 0.8.0 - windows services milestone Jun 6, 2014
@muuki88
Copy link
Contributor

muuki88 commented Jun 6, 2014

ping @jlandahl

@jlandahl
Copy link
Author

jlandahl commented Jun 6, 2014

Yes, it worked for me, thanks!
On May 30, 2014 1:15 AM, "Muki" [email protected] wrote:

@jlandahl https://github.com/jlandahl , did my suggested solution work
for you? If so, I close this pr. Thanks anyway :)


Reply to this email directly or view it on GitHub
#265 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants