-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented the changelog to RPM #332
Conversation
Thanks @antonini code looks solid and a big plus for the extensive documentation. Only all small test would be awesome which uses the new feature :-) In the wiki is a small developer guide ( which you may already found ) if you have |
Hi @muuki88 , I added on the test project the changelog generation. |
Hi @muuki88, Did I implemented the tests correct? Is there any other thing to be implement it? Or to assert the test? |
@@ -5,6 +5,7 @@ package rpm | |||
import linux.{ LinuxPackageMapping, LinuxFileMetaData } | |||
import sbt._ | |||
import com.typesafe.sbt.packager.linux.LinuxSymlink | |||
import java.nio.file.{ Paths, Files } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I overlooked this line. We are currently Java compatible, so you can't use NIO here :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh.. :(
And what should I use instead of it?
Em 26/08/2014, às 12:08, Nepomuk Seiler [email protected] escreveu:
In src/main/scala/com/typesafe/sbt/packager/rpm/RpmMetadata.scala:
@@ -5,6 +5,7 @@ package rpm
import linux.{ LinuxPackageMapping, LinuxFileMetaData }
import sbt._
import com.typesafe.sbt.packager.linux.LinuxSymlink
+import java.nio.file.{ Paths, Files }
I overlooked this line. We are currently Java compatible, so you can't use NIO here :-(—
Reply to this email directly or view it on GitHub.
Now I've found how to create the automated test. Fixed the compatibility problem and added the automated test. I hope it's fine now! :) |
Awesome! Thanks a lot. |
Implemented the changelog to RPM
merged into |
Implemented a way to import a changelog file to the generated RPM.
Also added a sample on the documentation of the rpm generation.
This was requested on issue #330.