Working on #42 #44
Working on #42 #44
Conversation
| @@ -3,40 +3,6 @@ | |||
| ### ------------------------------- ### | |||
| ### Helper methods for BASH scripts ### | |||
| ### ------------------------------- ### | |||
|
|
|||
| realpath () { | |||
There was a problem hiding this comment.
As you saw in the other thread, I'd rather not remove this method, as I don't think the workaround you have here will fit all the environments we've had issues in :). Check out the other pull request for a different solution.
- Added simple upstart script - Added Keys - Added Tasks - Incremented sbt version to 0.13.0 for testing (maybe reverted in next commits) Moving upstart script to DebianPlugin and adding TaskKeys #42
* Created a new java_server archetype for projects. * Moved upstart configuration into java_server archetype * Moved chmod method into common, hacky location.
|
Ok, I ran some cleanup on this here: 5243356 Let me know what you think. Doing some tests now, seeing if I can get an automated one. |
|
I have merged everything and tested it. Things that should be added in future versions are:
|
|
Cool! Thanks much on all your help. I can't wait for this feature to be in. |
* Typo was causing upstart script to be ignored in favor of bash. * For some reason chdir wasn't working on my local ubuntu. Workaround issued.
* Create new tasks which genreate prerem/postinst scripts * Automatically use files generated by these tasks, if they exist. * Java server archetype now automatically creates prerem/postinst scripts to start up the service upon install.
|
Alright, I went through and wired just thenecessary changes to make the remaining upstart work go. I've installed/uninstall my first server-based debian now, and it appears to be running quite smooth! Do you mind doing a code-review to make sure I implemented the things you suggest correctly? https://github.com/sbt/sbt-native-packager/tree/wip/jsuereth-upstart If so, I'll work on documentation next and make sure this goes out iwth the next release (0.7)! Again, thanks very very much for the contributions. |
|
Everything works fine, except the debianUpstartScriptReplacements <<= (maintainer in Debian, packageSummary in Debian, normalizedName, sbt.Keys.version) map { (author, descr, name, version) =>
// TODO name-version is copied from UniversalPlugin. This should be consolidated into a setting (install location...)
val chdir = GenericPackageSettings.installLocation + "/" + name + "/bin"
JavaAppUpstartScript.makeReplacements(author = author, descr = descr, execScript = name, chdir = chdir)Also the val chdir = GenericPackageSettings.installLocation + "/" + name + "-" + version + "/bin"should be changed to val chdir = GenericPackageSettings.installLocation + "/" + name + "/bin" |
|
Should I provide another commit for this? |
|
Please do. I hope to get back to this shortly to fill out the documentation. Requires some new pages and flow, so it may be a while, but we can merge into master.... |
Changing 'chdir' to correct path. Ticket #42
|
There you go :) Is there a schedule for the next release? Would be awesome to use this in play 2.2.0! |
|
Great, Thanks so much for the patch work! The schedule is a bit loose, as I have a few other bugs to finish, but it should be within the next few weeks. |
|
Awesome 👍 |
This is a first draft. Please review if this is okay.
commits)
What's left
Currently I have no idea where to put the Task so I can activate them. Hints appreciated.
After I fixed this, I will test this with play and may revert the sbt version to 0.12.4 .