overridable bash and bat templates #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for resolving this feature request. Code looks solid. Could you add test and some docs on how to use? |
|
I've added tests and some documentation, let me know if I should add anything else. |
|
Nice! One last thing, could you squash your commits into one? |
Merged
|
Done :) |
muuki88
added a commit
that referenced
this pull request
Aug 10, 2015
overridable bash and bat templates
|
Awesome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements feature request #635.
I left the old method signatures in the
JavaAppStartScripttrait, for backwards compatibility. Is this something that you could use? Should I add an example test project demonstrating this feature?