SystemD services now source /etc/default/{{app_name}} (resolves #737) #745
Conversation
|
@muuki88, this change is done and tested (lamentably, only under Debian Linux). What are your thoughts on my approach? I'd like to get some feedback on it before recommending it for merge. |
| @@ -9,3 +9,4 @@ project/project | |||
| log/ | |||
| target/ | |||
| .cache | |||
| .ensime* | |||
There was a problem hiding this comment.
pure personal interest: what editor do you use with ensime?
There was a problem hiding this comment.
I'd like to recommend emacs + evil (:
There was a problem hiding this comment.
That's it! Emacs and evil :)
|
I like the implementation a lot. We add further customization without touching the existing solution. If you add one test for the customization and some documentation this PR is from my perspective ready to merge |
timcharper
force-pushed
the
master
branch
2 times, most recently
from
36c6622 to
65facca
Compare
| /* etcDefaultConfig is dependent on serverLoading (systemd, systemv, etc.), | ||
| * and is therefore distro specific. As such, these settings cannot be defined | ||
| * in the global config scope. */ | ||
| private val etcDefaultConfig: Seq[Setting[_]] = Seq( |
There was a problem hiding this comment.
I don't understand this; private[this] is not smaller than private.
There was a problem hiding this comment.
scala> trait A { private val a = 1 }
defined trait A
scala> object B extends A { println(a) }
<console>:11: error: not found: value a
object B extends A { println(a) }
^
There was a problem hiding this comment.
What ? Codacy is clearly wrong here. Protected is visible by subclasses. Private is not. It has always been that way.
This change modifies the SystemD template to include the packaged /etc/default environment settings file. Since a sourced SystemD environment file is not the same thing as a bourne shell source script, a different template is used. Those deploying their package to multiple platforms can also specify different /etc/default templates by suffixing `-systemd` to their name, ie: src/templates/etc-default-systemd
|
@muuki88 Quick ping to say I've done as you've requested and everything's green again. |
SystemD services now source /etc/default/{{app_name}} (resolves #737)
|
Awesome. Thanks a lot, I will try to release an RC |
|
\o/ |
This change modifies the SystemD template to include the packaged
/etc/default environment settings file. Since a sourced SystemD
environment file is not the same thing as a bourne shell source script,
a different template is used.
Those deploying their package to multiple platforms can also specify
different /etc/default templates by suffixing
-systemdto their name,ie: src/templates/etc-default-systemd