Prevent empty double quotes in start daemon line. #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muuki88
requested changes
May 17, 2017
| @@ -22,47 +22,45 @@ export JAVA_OPTS | |||
| # If program manages its own PID file then it | |||
| # should declare its location in PIDFILE | |||
| if [ -z "$PIDFILE" ]; then | |||
| create_pidfile=true | |||
| PIDFILE=/var/run/${{app_name}}/running.pid | |||
| create_pidfile=true | |||
There was a problem hiding this comment.
Why these formatting changes?
| else | ||
| start-stop-daemon --background --chdir ${{chdir}} --chuid "$DAEMON_USER" --pidfile "$PIDFILE" --startas "$RUN_CMD" --start -- $RUN_OPTS ${stdout_redirect} | ||
| fi | ||
| log_end_msg $? |
There was a problem hiding this comment.
It's hard to see the actual changes with all the formatting changes. Can you remove the formatting?
The removal of the quotes should fix this if no `stdout_redirect` is set.
|
I've removed the formatting changes and will commit them in seperate pull request. They were just done to have a consistent indenting in the file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of the quotes should fix this if no
stdout_redirectis set. Also the file had mixed indenting of 2 and 4 spaces, therefore I adjusted it to 2 spaces.This should fix #955 . Travis is green on our fork: https://travis-ci.org/wegtam/sbt-native-packager/branches .