Add Setting for Docker User #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @apeschel, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
Currently, there is no way to set the organizaiton or user for a docker image. The documented practice is to misuse the dockerRepository setting to set the username or organization. However, there is already functionality in place for the DockerAlias class to support a separate username. This commit adds a dockerUsername setting which ties into the existing DockerAlias username functionality.
apeschel
force-pushed
the
feature/apeschel/docker_user
branch
from
3d707c8 to
9044c6b
Compare
|
Hi @apeschel, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
muuki88
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to set the organizaiton or user for a docker
image. The documented practice is to misuse the dockerRepository setting
to set the username or organization. However, there is already
functionality in place for the DockerAlias class to support a separate
username.
This commit adds a dockerUsername setting which ties into the existing
DockerAlias username functionality.