Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Refine checkReleasedTastyVersion logic to handle using unstable reference version of a new minor #22789

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

WojciechMazur
Copy link
Contributor

@WojciechMazur WojciechMazur commented Mar 13, 2025

In #22786 we've followed the process and updated referenceVersion to latest released version which happens to be 3.7.0-RC1 producing TASTY 28.7-experimental-1.
All nightly version when patch > 0 should be using TASTy version incremented by 1, in case of unexpected binary breakage. However non-bootstrapped tests (eg. FromTastyTest) would fail if we'd increase tasty version to 28.8-experimental-1 because these require the produced and consumed Scala files (eg. in FromTastyTest) to either:

  • be produced by older stable compiler
  • produced with exactly the same TASTy version

Because of that we're adding special case to checking version of released tasty to allow using the same tasty format as unstable reference version if the reference version is the RC release of new minor (patch == 0)

Fixes #22788

[skip ci]

…en using unstable reference version for the new minor
@WojciechMazur WojciechMazur requested a review from tgodzik March 13, 2025 09:13
@WojciechMazur WojciechMazur merged commit a986531 into scala:main Mar 13, 2025
29 checks passed
@WojciechMazur WojciechMazur deleted the refine/checkReleaseVersion branch March 13, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly Dotty workflow of 2025-03-13 failed
2 participants