Support scalafixDependencies #9
Conversation
This PR improves support for custom rules that are published to Maven Central. This functionality is required for rules like scala-collection-compat. We do a best-effort to avoid redundant dependency fetching of `scalafixDependencies` by caching the results in an in-memory map. In the future, it would make sense to expose more powerful APIs in scalafix to cache classloaders between invocations.
build.sbt
Outdated
| @@ -20,7 +20,7 @@ developers := List( | |||
| resolvers += Resolver.sonatypeRepo("releases") | |||
| libraryDependencies ++= List( | |||
| "org.eclipse.jgit" % "org.eclipse.jgit" % "4.5.4.201711221230-r", | |||
| "com.geirsson" %% "coursier-small" % "1.0.0-M2", | |||
| "com.geirsson" %% "coursier-small" % "1.0.0-M4", | |||
There was a problem hiding this comment.
Add a comment why we need this. GitHub repo link. I guess it's coursier 1.0.0-M4. Why not the latest version?
There was a problem hiding this comment.
Done, added a comment.
| Right(ScalafixInterface.classloadInstance()) | ||
| val dep = new Dependency( | ||
| "ch.epfl.scala", | ||
| s"scalafix-cli_${BuildInfo.scala212}", |
There was a problem hiding this comment.
What if we keep the "g" % "a" %% "v"syntax and assert that the scalaVersion == BuildInfo.scala212 ? To me this feels more natural, because I always use %% for scala library.
There was a problem hiding this comment.
This is not the syntax for scalafixDependencies, this is the coursier-small API that users won't observe
There was a problem hiding this comment.
See basic/build.sbt for an example scalafixDependencies usage
| ), | ||
| scalafixDependencies := List( | ||
| // Custom rule published to Maven Central https://github.com/olafurpg/example-scalafix-rule | ||
| "com.geirsson" % "example-scalafix-rule_2.12" % "1.1.1" |
There was a problem hiding this comment.
Should be "com.geirsson" %% "example-scalafix-rule" % "1.1.1"
There was a problem hiding this comment.
That won't work for the scripted tests on 0.13
Fixes #7.
This PR improves support for custom rules that are published to Maven
Central. This functionality is required for rules like
scala-collection-compat. We do a best-effort to avoid redundant
dependency fetching of
scalafixDependenciesby caching the resultsin an in-memory map. In the future, it would make sense to expose more
powerful APIs in scalafix to cache classloaders between invocations.