Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop automatic installation of semanticdb-scalac #589

Closed
olafurpg opened this issue Jan 31, 2018 · 2 comments · Fixed by #665 or #666
Closed

Stop automatic installation of semanticdb-scalac #589

olafurpg opened this issue Jan 31, 2018 · 2 comments · Fixed by #665 or #666
Milestone

Comments

@olafurpg
Copy link
Contributor

Currently, sbt-scalafix automatically addCompilerPlugin(semanticdb-scalac) and scalacOptions += "-Yrangepo". This automatic setup does not work for builds that use libraryDependencies := or scalacOptions :=. I propose we stop with the automatic installation and recommend users to manually setup the compiler plugin

addCompilerPlugin("org.scalameta" % "semanticdb-scalac" % scalafixScalametaVersion.value  % cross CrossVersion.full)
scalacOptions += "-Yrangepos"

Alternatively, it's possible to configure this step with the scalafixEnable command for a single sbt session.

@olafurpg olafurpg added this to the v0.6.0 milestone Jan 31, 2018
@MasseGuillaume
Copy link
Contributor

@olafurpg why we don't reuse the logic of scalafixEnable? If semanticdb-scalac don't add it, etc.

@olafurpg
Copy link
Contributor Author

We currently enable the settings from scalafixEnable in ScalafixPlugin. The problem is that many build.sbt override the settings defined by ScalafixPlugin, making the setup break. The scalafixEnable command bypasses this problem because you have to run it manually in the sbt shell after the build is loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants