Remove automatic installation of semanticdb-scalac #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, addSbtPlugin(sbt-scalafix) would automatically enable the semanticdb-scalac compiler plugin and -Yrange scalac options. This commit removes the automatic installation so that users now need to manually enable the following settings ``` addCompilerPlugin(scalafixSemanticdb) scalacOptions += "-Yrangepos" ``` This makes the installation consistent for all users regardless of what order they define libraryDependencies and scalacOptions. The installation documentation for sbt-scalafix was pretty complex before because the automatic setup only worked sometimes.
Custom sourceroots are an esoteric feature that is not worth maintaining.
This allows us to add more changes without forcing the scalafix website to show docs for milestone releases
olafurpg
force-pushed
the
add-compiler-plugin
branch
from
bd4515a to
c062c20
Compare
olafurpg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #665 that was reverted after merge. Let's not merge this until all changes for v0.6 are ready. I have one more pending PR before it's safe to merge this PR.
Previously, addSbtPlugin(sbt-scalafix) would automatically enable the
semanticdb-scalac compiler plugin and -Yrange scalac options.
This commit removes the automatic installation so that users now need to
manually enable the following settings
This makes the installation consistent for all users regardless of what
order they define libraryDependencies and scalacOptions.
The installation documentation for sbt-scalafix was pretty complex
before because the automatic setup only worked sometimes.
Fixes #589
PS. Right after merging this PR we should immediately cut a v0.6.0-M2 release in order to make the installation instructions up-to-date.