improvement: queue or cancel previous connect request #6691
Conversation
kasiaMarek
force-pushed
the
cancel-build-server-connection
branch
4 times, most recently
from
b1564af to
3f2a29b
Compare
| @@ -211,18 +212,12 @@ class SbtBloopLspSuite | |||
| _ = assertNoDiff( | |||
| client.beginProgressMessages, | |||
| List( | |||
| progressMessage, | |||
There was a problem hiding this comment.
We don't deduplicate like this anymore. Instead requests will be queued and the first one will get cancelled. So sbt bloopInstall will be executed twice, and the first request will be cancelled after that, so import and indexing are executed only once.
| val iter = queue.iterator() | ||
| while (iter.hasNext()) { | ||
| val curr = iter.next() | ||
| request.cancelCompare(iter.next().request) match { |
There was a problem hiding this comment.
Could you explain the logic a bit better here? Could we use some case objects instead of just numbers?
|
|
||
| class Interruptable[+T] private ( | ||
| futureIn: Future[T], | ||
| cancelPromise: Promise[Unit], |
There was a problem hiding this comment.
Are we able to forward the cancel request to an underlying process if for example bloopInstall is running?
kasiaMarek
force-pushed
the
cancel-build-server-connection
branch
from
3f2a29b to
044cc69
Compare
kasiaMarek
force-pushed
the
cancel-build-server-connection
branch
from
044cc69 to
22a9bb1
Compare
metals/src/main/scala/scala/meta/internal/metals/Interruptable.scala
Outdated
Show resolved
Hide resolved
| case class Index(check: () => Unit) extends ConnectRequest { | ||
| def cancelCompare(other: ConnectRequest): ConflictBehaviour = | ||
| other match { | ||
| case _: Disconnect => Queue |
There was a problem hiding this comment.
If we have a Disconnect then we should probably Yield, no? There is no sense to run idnexing after disconnecting?
| def cancelCompare(other: ConnectRequest): ConflictBehaviour = | ||
| other match { | ||
| case (_: Index) | (_: ImportBuildAndIndex) => TakeOver | ||
| case _: Disconnect => Queue |
There was a problem hiding this comment.
Same here if we have Disconnect, we should probably just cancel everything and not lose time on import.
|
I don't see any changes since last time, did you forget to push them or my comments were not valid? |
Sorry, my bad. |
No description provided.