fix: generate auto-imports for more pattern completions #7292
+85
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tweaks the case-completion logic to always take auto-imports into
account. The auto-import logic was present for known direct subclasses,
but not for some other cases. Now, they all get handled uniformly.
The only hair in the soup is that extra work needs to go in to
def myList: List[Int]
myList match {
case N@@ // want `case Nil =>`, not `case immutable.Nil =>`
}
Reason here is that the `Nil` variant is completing with
`scala.collection.immutable.Nil`, while only `scala.Nil` is in scope.
The `scala.*` package re-exports are narrowly worked around since they
probably would occur frequently.
tgodzik
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the case-completion logic to always take auto-imports into account. The auto-import logic was present for known direct subclasses, but not for some other cases. Now, they all get handled uniformly.
The only hair in the soup is that extra work needs to go in to
Reason here is that the
Nilvariant is completing withscala.collection.immutable.Nil, while onlyscala.Nilis in scope. Thescala.*package re-exports are narrowly worked around since they probably would occur frequently.