fix: colliding pattern and scope completions #7295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpocrates
commented
Mar 12, 2025
| ) | ||
| if (patternOnly.nonEmpty && name == pattern) { |
There was a problem hiding this comment.
This is a case to ensure that in something like
Option(123) match {
case No@@
}you only see None once instead of once for something from match completions then again from the general scope completions. Said differently, this is an exception where we want the match completions and general scope completions to collide so we see only one of them.
This ensures that scope-based completions show up in a pattern context, even if the symbol to complete is the same as the one underlying a pattern completion (see the `underscore-and-object` test added) This is achieved by putting case pattern completions in a new completion member with its own dedup-ing `id`. Although it turned out to not matter in this specific case, also fixed `inverseSemanticdbSymbol` incorrectly returning an object symbol for some class symbols. That tweak on its own didn't affect any test output.
harpocrates
force-pushed
the
completion-object
branch
from
5ccc69b to
a96f54a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that scope-based completions show up in a pattern context, even if the symbol to complete is the same as the one underlying a pattern completion (see the
underscore-and-objecttest added)This is achieved by putting case pattern completions in a new completion member with its own dedup-ing
id.Although it turned out to not matter in this specific case, also fixed
inverseSemanticdbSymbolincorrectly returning an object symbol for some class symbols. That tweak on its own didn't affect any test output.fixes #7291