Use unmanagedSourceDirectories for sourceDirectories #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sourceDirectories in hasScalafmt` is currently initialized with `List(scalaSource.value)` which means that scalafmt only looks into one source directory per project. But a typical Scala.js cross project has at least two source directories js/ and shared/ or jvm/ and shared/. Sometimes there are also multiple source directories for different Scala versions. This change initializes `sourceDirectories in hasScalafmt` with `unmanagedSourceDirectories` which contains all source directories with manually created sources. In my tests `unmanagedSourceDirectories` always includes `scalaSource`. Here are for example both settings for typelevel/cats: > coreJVM/scalaSource [info] cats/core/.jvm/src/main/scala > coreJVM/unmanagedSourceDirectories [info] List( cats/core/.jvm/src/main/scala-2.11, cats/core/.jvm/src/main/scala, cats/core/.jvm/src/main/java, cats/core/src/main/scala) And since cats has no sources in cats/core/.jvm/src/main/scala, scalafmt won't format anything.
Current coverage is 90.57%@@ master #229 diff @@
==========================================
Files 30 30
Lines 1633 1633
Methods 1529 1529
Messages 0 0
Branches 104 104
==========================================
Hits 1479 1479
Misses 154 154
Partials 0 0
|
|
I should mention that I've tested this with refined and it allowed to get rid of this workaround. |
|
From the sbt documentation:
Nice. Thanks a lot @fthomas 😄 |
|
For the sake of completeness, this is how unmanagedSourceDirectories := makeCrossSources(
scalaSource.value, javaSource.value, scalaBinaryVersion.value, crossPaths.value) |
This was referenced Jul 11, 2017
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourceDirectories in hasScalafmtis currently initialized withList(scalaSource.value)which means that scalafmt only looks intoone source directory per project. But a typical Scala.js cross
project has at least two source directories js/ and shared/ or
jvm/ and shared/. Sometimes there are also multiple source
directories for different Scala versions.
This change initializes
sourceDirectories in hasScalafmtwithunmanagedSourceDirectorieswhich contains all source directorieswith manually created sources. In my tests
unmanagedSourceDirectoriesalways includesscalaSource.Here are for example both settings for typelevel/cats:
And since cats has no sources in cats/core/.jvm/src/main/scala,
scalafmt won't format anything.