Use unmanagedSourceDirectories for sourceDirectories #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourceDirectories in hasScalafmt
is currently initialized withList(scalaSource.value)
which means that scalafmt only looks intoone source directory per project. But a typical Scala.js cross
project has at least two source directories js/ and shared/ or
jvm/ and shared/. Sometimes there are also multiple source
directories for different Scala versions.
This change initializes
sourceDirectories in hasScalafmt
withunmanagedSourceDirectories
which contains all source directorieswith manually created sources. In my tests
unmanagedSourceDirectories
always includesscalaSource
.Here are for example both settings for typelevel/cats:
And since cats has no sources in cats/core/.jvm/src/main/scala,
scalafmt won't format anything.