-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy Metadata in Backbeat tests #2610
Conversation
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 13 files with indirect coverage changes
@@ Coverage Diff @@
## development/9.0 #2610 +/- ##
===================================================
+ Coverage 71.41% 73.18% +1.77%
===================================================
Files 201 201
Lines 13366 13366
===================================================
+ Hits 9545 9782 +237
+ Misses 3811 3574 -237
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
1346554
to
0c28ec8
Compare
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/improvement/BB-496 && \
git merge origin/development/9.0 Resolve merge conflicts and commit git push origin HEAD:improvement/BB-496 |
c4ed1bd
to
f879fa3
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
090fb4b
to
b5df0cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these not be just another "functional" test? (folder & ft_test:queuepopulator
yarn target)
- it is not really "end-2-end", since we still deploy (some) mocks, and do not use the same deployment as in the product
- it is similar to the funcitonal tests, in the sense that we run an "real" backbeat service, and the tests are running in separate process
- it does not replace (or try to) the actual e2e tests we have in Zenko
43ffbf0
to
eb563b7
Compare
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/improvement/BB-496 && \
git merge origin/development/9.0 Resolve merge conflicts and commit git push origin HEAD:improvement/BB-496 |
eb563b7
to
9bb46f9
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
9bb46f9
to
da9bebe
Compare
2caa8ca
to
e49f23b
Compare
Launching sproxyd directly without supervisord or an nginx proxy Issue: BB-496
824b40d
to
2b10733
Compare
/approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue BB-496. Goodbye kerkesni. The following options are set: approve |
Issue: BB-496