Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Metadata in Backbeat tests #2610

Merged
merged 7 commits into from
Mar 3, 2025
Merged

Conversation

Kerkesni
Copy link
Contributor

@Kerkesni Kerkesni commented Jan 10, 2025

  • Deploy a metadata setup in a separate CI job
  • Add a minimal test for queue populator that uses the metadata backend

Issue: BB-496

@bert-e
Copy link
Contributor

bert-e commented Jan 10, 2025

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 10, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.18%. Comparing base (d963e52) to head (2b10733).
Report is 7 commits behind head on development/9.0.

Additional details and impacted files

Impacted file tree graph

see 13 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 75.37% <ø> (ø)
Core Library 79.74% <ø> (+3.47%) ⬆️
Ingestion 70.14% <ø> (ø)
Lifecycle 77.08% <ø> (+0.89%) ⬆️
Oplog Populator 85.06% <ø> (ø)
Replication 58.64% <ø> (+0.84%) ⬆️
Bucket Scanner 85.60% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.0    #2610      +/-   ##
===================================================
+ Coverage            71.41%   73.18%   +1.77%     
===================================================
  Files                  201      201              
  Lines                13366    13366              
===================================================
+ Hits                  9545     9782     +237     
+ Misses                3811     3574     -237     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.48% <ø> (ø)
api:routes 9.30% <ø> (ø)
bucket-scanner 85.60% <ø> (ø)
ft_test:queuepopulator 10.42% <ø> (?)
ingestion 12.56% <ø> (ø)
lib 7.33% <ø> (-0.01%) ⬇️
lifecycle 18.76% <ø> (ø)
notification 1.07% <ø> (ø)
replication 18.54% <ø> (ø)
unit 48.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bert-e
Copy link
Contributor

bert-e commented Jan 10, 2025

Conflict

There is a conflict between your branch improvement/BB-496 and the
destination branch development/9.0.

Please resolve the conflict on the feature branch (improvement/BB-496).

git fetch && \
git checkout origin/improvement/BB-496 && \
git merge origin/development/9.0

Resolve merge conflicts and commit

git push origin HEAD:improvement/BB-496

@Kerkesni Kerkesni force-pushed the improvement/BB-496 branch 2 times, most recently from c4ed1bd to f879fa3 Compare January 10, 2025 15:59
@bert-e
Copy link
Contributor

bert-e commented Jan 10, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni Kerkesni force-pushed the improvement/BB-496 branch 6 times, most recently from 090fb4b to b5df0cd Compare January 15, 2025 10:10
Copy link
Contributor

@francoisferrand francoisferrand Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these not be just another "functional" test? (folder & ft_test:queuepopulatoryarn target)

  • it is not really "end-2-end", since we still deploy (some) mocks, and do not use the same deployment as in the product
  • it is similar to the funcitonal tests, in the sense that we run an "real" backbeat service, and the tests are running in separate process
  • it does not replace (or try to) the actual e2e tests we have in Zenko

@Kerkesni Kerkesni force-pushed the improvement/BB-496 branch 3 times, most recently from 43ffbf0 to eb563b7 Compare February 11, 2025 11:59
@scality scality deleted a comment from bert-e Feb 17, 2025
@bert-e
Copy link
Contributor

bert-e commented Feb 25, 2025

Conflict

There is a conflict between your branch improvement/BB-496 and the
destination branch development/9.0.

Please resolve the conflict on the feature branch (improvement/BB-496).

git fetch && \
git checkout origin/improvement/BB-496 && \
git merge origin/development/9.0

Resolve merge conflicts and commit

git push origin HEAD:improvement/BB-496

@Kerkesni Kerkesni force-pushed the improvement/BB-496 branch from eb563b7 to 9bb46f9 Compare March 3, 2025 10:33
@bert-e
Copy link
Contributor

bert-e commented Mar 3, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni Kerkesni force-pushed the improvement/BB-496 branch from 9bb46f9 to da9bebe Compare March 3, 2025 10:33
@Kerkesni Kerkesni force-pushed the improvement/BB-496 branch 4 times, most recently from 2caa8ca to e49f23b Compare March 3, 2025 14:20
@Kerkesni Kerkesni force-pushed the improvement/BB-496 branch from 824b40d to 2b10733 Compare March 3, 2025 14:53
@Kerkesni
Copy link
Contributor Author

Kerkesni commented Mar 3, 2025

/approve

@bert-e bert-e merged commit 2b10733 into development/9.0 Mar 3, 2025
10 checks passed
@bert-e
Copy link
Contributor

bert-e commented Mar 3, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6

Please check the status of the associated issue BB-496.

Goodbye kerkesni.

The following options are set: approve

@bert-e bert-e deleted the improvement/BB-496 branch March 3, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants