Fix Kafka LogReader failing when attempting to store offsets in Zookeeper

[Kerkesni]

Kafka manages the offsets when using Kafka logReader. Skipped step in code where we attempt to store the offset in Zookeeper when using the Kafka LogReader.

Issue: BB-481

[bert-e]

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue BB-481 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.0.0

Please check the Fix Version/s of BB-481, or the target
branch of this pull request.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.34%. Comparing base (68b9838) to head (403c1be).
Report is 1 commits behind head on development/9.0.

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/queuePopulator/KafkaLogReader.js	66.66% <100.00%> (+1.96%)	⬆️
lib/queuePopulator/LogReader.js	80.79% <100.00%> (+0.21%)	⬆️

... and 3 files with indirect coverage changes

Components	Coverage Δ
Bucket Notification	75.37% <ø> (ø)
Core Library	80.14% <100.00%> (-0.06%)	⬇️
Ingestion	70.14% <ø> (ø)
Lifecycle	77.08% <ø> (ø)
Oplog Populator	85.06% <ø> (ø)
Replication	58.60% <ø> (ø)
Bucket Scanner	85.60% <ø> (ø)

@@                 Coverage Diff                 @@
##           development/9.0    #2615      +/-   ##
===================================================
- Coverage            73.36%   73.34%   -0.03%     
===================================================
  Files                  201      201              
  Lines                13370    13374       +4     
===================================================
  Hits                  9809     9809              
- Misses                3551     3555       +4     
  Partials                10       10              

Flag	Coverage Δ
api:retry	9.48% <0.00%> (-0.01%)	⬇️
api:routes	9.29% <0.00%> (-0.01%)	⬇️
bucket-scanner	85.60% <ø> (ø)
ft_test:queuepopulator	10.17% <60.00%> (-0.55%)	⬇️
ingestion	12.56% <40.00%> (+0.01%)	⬆️
lib	7.31% <0.00%> (-0.02%)	⬇️
lifecycle	18.75% <0.00%> (+<0.01%)	⬆️
notification	1.06% <0.00%> (-0.01%)	⬇️
replication	18.53% <0.00%> (-0.01%)	⬇️
unit	48.56% <100.00%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[francoisferrand]

this includes some old commit & fixups, please rebase on latest and cleanup history.

[bert-e]

Incorrect fix version

The Fix Version/s in issue BB-481 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.0.1

Please check the Fix Version/s of BB-481, or the target
branch of this pull request.

[francoisferrand]

probably the last one for 9.0.1, should bump? Or to you prefer to merge this one after the release?

[Kerkesni]

/approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/9.0

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.6

Please check the status of the associated issue BB-481.

Goodbye kerkesni.

The following options are set: approve