fix tests

scinfu · Feb 28, 2025 · cb3ebdc · cb3ebdc
1 parent 18ad8b8
commit cb3ebdc
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/Sources/Node.swift b/Sources/Node.swift
@@ -29,9 +29,10 @@ open class Node: Equatable, Hashable {
     weak var parentNode: Node? {
         didSet {
             guard oldValue !== parentNode, let element = self as? Element else { return }
-
-            oldValue?.updateQueryIndex(for: [element], adding: false)
-            parentNode?.updateQueryIndex(for: [element], adding: true)
+            let descendants = element.normalizedTagNameIndex.values.flatMap { $0.compactMap { $0.value } }
+            let forElements = [element] + descendants
+            oldValue?.updateQueryIndex(for: forElements, adding: false)
+            parentNode?.updateQueryIndex(for: forElements, adding: true)
         }
     }
 

diff --git a/Tests/SwiftSoupTests/ElementTest.swift b/Tests/SwiftSoupTests/ElementTest.swift
@@ -979,6 +979,20 @@ class ElementTest: XCTestCase {
         let bodyEls: Elements = try! doc.body()!.getElementsByTag("ruby")
         XCTAssertEqual(bodyEls.size(), els.size())
     }
+
+    func testGetElementsByTagIndexRegression() throws {
+        let h = "<p><u>test</u></p>"
+        let doc: Document = try SwiftSoup.parseBodyFragment(h)
+        let pBodyEls: Elements = try! doc.body()!.getElementsByTag("p")
+        XCTAssertEqual(1, pBodyEls.size())
+        let pEls: Elements = try! doc.getElementsByTag("p")
+        XCTAssertEqual(1, pEls.size())
+        let bodyEls: Elements = try! doc.body()!.getElementsByTag("u")
+        XCTAssertEqual(1, bodyEls.size())
+        let els: Elements = try! doc.getElementsByTag("u")
+        XCTAssertEqual(1, els.size())
+    }
+
 
 	static var allTests = {
 		return [
@@ -1055,6 +1069,7 @@ class ElementTest: XCTestCase {
             ("testChainedRemoveAttributes", testChainedRemoveAttributes),
             ("testIs", testIs),
             ("testGetElementsByTagIndexDuplicatesRegression", testGetElementsByTagIndexDuplicatesRegression),
+            ("testGetElementsByTagIndexRegression", testGetElementsByTagIndexRegression)
         ]
 	}()
 }