Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in ie8 #106

Closed
mikevierwind opened this issue Feb 13, 2012 · 16 comments
Closed

Crash in ie8 #106

mikevierwind opened this issue Feb 13, 2012 · 16 comments

Comments

@mikevierwind
Copy link

Internet explore in windows xp. Crashes when you load the website. When we put a background image on the body or html. Then the ie8 in windows xp is crasht. Can you fix this problem?

@scottjehl
Copy link
Owner

This should be fixed now - are you using the latest version in master? 1.1?

On Feb 13, 2012, at 8:23 PM, mikevierwind wrote:

Internet explore in windows xp. Crashes when you load the website. When we put a background image on the body or html. Then the ie8 in windows xp is crasht. Can you fix this problem?


Reply to this email directly or view it on GitHub:
#106

@IschaGast
Copy link

I made 6 test pages and 2 of them crashes in IE8 because there is a background-image on the body.
http://ischagast.nl/respond/test/

Testing done in IE8 on windows XP

++ http://ischagast.nl/respond/test/test.html
background-image on the body and the browser crashed

++ http://ischagast.nl/respond/test/test2.html
background-image on the body with a class and the browser doesn't crash

++ http://ischagast.nl/respond/test/test3.html
background-image on the body with an id and the browser doesn't crash

++ http://ischagast.nl/respond/test/test4.html
Background image added via inline styles and the browser doesn't crash

++ http://ischagast.nl/respond/test/test5.html
Background image added via styles in the head and the browser doesn't crash

++ http://ischagast.nl/respond/test/test6.html
Background image added via styles in the head but before the script and the browser doesn't crash

I hope this helps :)

@giodif
Copy link

giodif commented Feb 17, 2012

I had the same problem, so I attached the background image via a class and the problem stopped. Thanks for the testing IschaGast

@elyseholladay
Copy link

Hey Scott,

Still getting a hard crash. Made sure we have the latest, and we had bg images on the body, so we removed that, but it's still giving me a crash. http://stageapp.socialpakt.com if you have a second! :)

Elyse

@IschaGast
Copy link

Strange because when I look in Browserstack.com is doesn't crash anymore... have you cleared your browser cache etc...?

@fetis
Copy link

fetis commented Feb 21, 2012

I have the same issue.

this test http://ischagast.nl/respond/test/test.html crashed for me too

@artiswilliams
Copy link

We are experiencing this issue also. Background images on the hard crashes IE8 in Windows XP.

@theDanielJLewis
Copy link

Wow! I'm glad I checked here before giving up. I was having the same crashes. IE8 in IE8 Standards Mode, as well as IE9 crashes. I was actually on Windows Server 2008.

Upon reading the issues here, I changed my CSS to apply a background image to body via a class, and it worked!

It's a good thing that, at least in this design, I have the ability to do that to just the body. I can't easily add a class to html, which I also sometimes use for background-images in addition to body.

@joebanks10
Copy link

I had the same issue. I'm using v. 1.1. Removing the background image from the body tag prevented IE8 from crashing. This bug with IE8 seems to still exists (damn you, IE!).

@anthonycervantes
Copy link

We ran into the same issue. We updated matchMedia to use the same "fake body" logic that is found in respond.

I'm not sure that it mattered yet but we also added "background:none;" to the style for the test div and, if it was created, the fake body.

This cleared our issues on IE8.

Removing the background image on body wasn't a workable solution for us because we support a large number of skins/templates that can potentially set a background.

@joebotha
Copy link

joebotha commented Mar 9, 2012

Just to confirm another report of IE8 crashing. Adding a class to body and applying the image to that class did stop the crashing.

@scottjehl
Copy link
Owner

I'll add the background none workaround to fakebody in respond. Sounds like
a good idea.

On Fri, Mar 9, 2012 at 7:49 PM, joebotha <
[email protected]

wrote:

Just to confirm another report of IE8 crashing. Adding a class to body and
applying the image to that class did stop the crashing.


Reply to this email directly or view it on GitHub:
#106 (comment)

scottjehl pushed a commit that referenced this issue Mar 9, 2012
…background image is on body element. Addresses issue #106. Please confirm the fix!
@scottjehl
Copy link
Owner

Anyone mind testing the recent changes to master to see if this is resolved? Thanks!

On Mar 9, 2012, at 7:49 PM, joebotha wrote:

Just to confirm another report of IE8 crashing. Adding a class to body and applying the image to that class did stop the crashing.


Reply to this email directly or view it on GitHub:
#106 (comment)

@IschaGast
Copy link

My test pages don't crash in browserstack IE8 anymore, I like!

Great work Scott!

@scottjehl
Copy link
Owner

closing out! thanks

@cheeyeo
Copy link

cheeyeo commented Dec 21, 2012

Hi

this issue seems to cause problems in a recent site of mine on IE 8?

http://www.wineselectionltd.com/winetrust/product-category/white/

Invalid procecure call or argument respond.js

line 271 char 12

I'm using the master branch copy of respond.js

the test browser is IE 8 windows xp sp3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests