Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 2.6 #81

Merged
merged 4 commits into from
Dec 22, 2017
Merged

Drop support for EOL Python 2.6 #81

merged 4 commits into from
Dec 22, 2017

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 14, 2017

Latest master is failing on Python 2.6 because pytest no longer supports it.
https://travis-ci.org/hugovk/cssselect/builds/316469101

It was also suggested to drop it in #61 (comment):

+1 to drop Python 3.2 and Python 2.6 support.

Python 2.6 has been EOL for 4 years and hasn't received a security update since then. It's also little used.

Here's the pip installs for cssselect from PyPI for the last month (via pypinfo --percent --pip --markdown cssselect pyversion)

python_version percent download_count
2.7 63.8% 145,167
3.6 19.3% 43,801
3.5 11.3% 25,618
3.4 5.3% 12,157
3.7 0.2% 404
2.6 0.1% 250
3.3 0.1% 127
3.2 0.0% 7
None 0.0% 1

Python 3.3 is also EOL and even less used. Should that be dropped as well?

@codecov
Copy link

codecov bot commented Dec 14, 2017

Codecov Report

Merging #81 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   95.02%   95.25%   +0.23%     
==========================================
  Files           3        2       -1     
  Lines         703      695       -8     
  Branches      114      113       -1     
==========================================
- Hits          668      662       -6     
+ Misses         20       19       -1     
+ Partials       15       14       -1
Impacted Files Coverage Δ
cssselect/xpath.py 94.82% <100%> (ø) ⬆️
cssselect/parser.py 95.55% <100%> (+0.45%) ⬆️
cssselect/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3036cba...1060ca1. Read the comment docs.

Copy link
Contributor

@redapple redapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @hugovk !

@hugovk
Copy link
Contributor Author

hugovk commented Dec 14, 2017

@redapple What do you think about dropping EOL Python 3.3?

@kmike
Copy link
Member

kmike commented Dec 22, 2017

Thanks @hugovk!

What do you think about dropping EOL Python 3.3?

I guess an argument against dropping 3.3 could be that lxml still supports Python 3.3, and cssselect is documented at http://lxml.de/cssselect.html, so we may keep 3.3 in respect. But we're dropping 2.6 (which lxml also supports), so this argument is not good :) I'm fine with dropping 3.3 as well.

@kmike kmike merged commit 7ed6813 into scrapy:master Dec 22, 2017
@hugovk hugovk deleted the rm-2.6 branch December 22, 2017 04:34
@hugovk
Copy link
Contributor Author

hugovk commented Dec 22, 2017

See PR #82 to drop 3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants