Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete autocomplete space if punctuation follows #169

Closed
2 tasks done
andrewtavis opened this issue Jun 8, 2022 · 2 comments
Closed
2 tasks done

Delete autocomplete space if punctuation follows #169

andrewtavis opened this issue Jun 8, 2022 · 2 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Jun 8, 2022

Terms

Description

This is a feature that would be helpful to include once autocomplete is included in Scribe. The feature is deleting the space that's provided after the completion if the following character is punctuation that ends a sentence ., ? and !.

Contribution

This won't be worked on for a while, but I'd be happy to work on it when it is :)

@andrewtavis andrewtavis added feature New feature or request blocked Another issue is blocking labels Jun 8, 2022
@andrewtavis andrewtavis added help wanted Extra attention is needed good first issue Good for newcomers and removed blocked Another issue is blocking labels Oct 8, 2022
@andrewtavis
Copy link
Member Author

Generally their could also be a check when one of these keys is pressed where if there's a space before, then it's deleted. I don't really see the outlier of them wanting a space before to be too important to not include something that could be helpful :) But to make this more specific we could check whether commandState == .suggest :)

@andrewtavis
Copy link
Member Author

Closed in ca85664 :)

@andrewtavis andrewtavis self-assigned this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant